Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112867
MIME-Version: 1.0
References: <CAEPJdu=kopidV44A01Sjv_eLq_fkLsjVuzqXx+j9b9gCahn2Vg@mail.gmail.com>
 <CAFPFaMK6LpF=1EoPXrJBJjEKKO7LVKEzw6oExMT_49aRQwoFWQ@mail.gmail.com>
In-Reply-To: <CAFPFaMK6LpF=1EoPXrJBJjEKKO7LVKEzw6oExMT_49aRQwoFWQ@mail.gmail.com>
Date: Wed, 13 Jan 2021 13:34:00 +0100
Message-ID: <CADyq6sLgsGdxkA7Pgrk9vzxf13d0uRefxPRcd4hQO2ejZWwgdQ@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000400c0605b8c75bfc"
Subject: Re: [PHP-DEV] #[Deprecated] Attribute
From: ocramius@gmail.com (Marco Pivetta)

--000000000000400c0605b8c75bfc
Content-Type: text/plain; charset="UTF-8"

On Sun, Jan 10, 2021 at 2:48 AM G. P. B. <george.banyard@gmail.com> wrote:

> Just to clarify this raises an E_DEPRECATED right?
> Could it make sense to raise E_USER_DEPRECATED instead?
>

I hadn't checked this before, but as per George's message, this is worrying.

I've been quite loud about it in the past, but static metadata definitions
should really not lead to runtime side-effects, especially if not pure
(error handling system tripped here).

I'd be totally for a built-in `#[Deprecated]` attribute if it did **NOT**
have a runtime behavior, which is an absolute no-go from my PoV.

This stuff is easily introspectible via tools like phpstan, psalm, phan,
and does not need to lead to more problematic runtime issues.

Marco Pivetta

http://twitter.com/Ocramius

http://ocramius.github.com/

--000000000000400c0605b8c75bfc--