Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112866
X-MailCleaner-return_path: brendt@stitcher.io
X-MailCleaner-sender_address: brendt@stitcher.io
X-MailCleaner-recipients: internals@lists.php.net
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Wed, 13 Jan 2021 13:05:01 +0100
References: <CAEPJdu=kopidV44A01Sjv_eLq_fkLsjVuzqXx+j9b9gCahn2Vg@mail.gmail.com>
 <CAOWwgpmwdxnwb+NcHcd59ySwbKKB_1C1nYtPeGkmPXa8F3GXPg@mail.gmail.com>
 <CAESVnVpjyhCH1K5sOHzp8qoa7hUAhRqpfN90JS3CooyFpEOZ2Q@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
In-Reply-To: <CAESVnVpjyhCH1K5sOHzp8qoa7hUAhRqpfN90JS3CooyFpEOZ2Q@mail.gmail.com>
Message-ID: <B802520B-C807-4CA4-A462-EF3E6FB33FF8@stitcher.io>
X-Mailer: Apple Mail (2.3608.120.23.2.4)
X-MailCleaner-TrustedIPs: Ok
Subject: Re: [PHP-DEV] #[Deprecated] Attribute
From: brendt@stitcher.io (Brent Roose)

Hi Sara

> On 22 Dec 2020, at 19:54, Sara Golemon <pollita@php.net> wrote:
>=20
> On Tue, Dec 22, 2020 at 12:35 PM Nicolas Grekas <
> nicolas.grekas+php@gmail.com> wrote:
>=20
>> It would be great to allow adding this attribute on classes. What =
about
>> allowing it right now and not bind it to any runtime side-effect? =
That
>> would allow static analyzers to do their job. Same for consts and
>> properties by the way.
>>=20
>> Also, it would be very useful to add named parameters to the =
attribute,
>> namely: "package" (the name of the package that declares the =
deprecation)
>> and "version" (the version of that package that introduced the
>> deprecation), next to the message.
>>=20
>> This is critical info when building reports of deprecations.
>>=20
>>=20
> You could do that now with a polyfill from userspace.  If the =
annotation
> need not have an effect, then it's just any other userspace =
implementation.

The difference is that PHP core has the ability to force standarization. =
There's already JetBrains' implementation of #[Deprecated], which Psalm =
and PhpStan also support, but it's not a real standard. Maybe the FIG =
would one day step in to decide these kinds of things, but the reality =
is that many major frameworks don't follow FIG as closely as they used =
to. I think there's value in adding attributes in the core, with the =
goal only being static analysis. It'll allow for consistency and that's =
a valuable thing.

>=20
> -Sara


Kind regards
Brent=