Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112858
To: internals@lists.php.net
References: <CAF+90c8Euq9nTMeoeUJ3a6s3wyj_DqbOeXoh07oDeUy6PeCefA@mail.gmail.com>
 <CADyq6sKx0wnq__p-dy3=bovHZ=Uzu=QN2Ko6OLmiGj47BrBNeQ@mail.gmail.com>
 <CAPyj-LAciv_XS+ML2FnbkXeZRQONOe-qFm9d6_J+OdVK2AOyOw@mail.gmail.com>
Message-ID: <708bdb8a-c653-5f7e-7efc-b1c22fefafdd@processus.org>
Date: Tue, 12 Jan 2021 19:43:30 +0100
MIME-Version: 1.0
In-Reply-To: <CAPyj-LAciv_XS+ML2FnbkXeZRQONOe-qFm9d6_J+OdVK2AOyOw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Allow object keys in arrays
From: pierre-php@processus.org ("Pierre R.")

Le 12/01/2021 à 17:35, Ilija Tovilo a écrit :
> Hi Marco
>
> On Tue, Jan 12, 2021 at 5:19 PM Marco Pivetta <ocramius@gmail.com> wrote:
>
>> On Mon, Jan 11, 2021, 15:29 Nikita Popov <nikita.ppv@gmail.com> wrote:
>>
>>> Hi internals,
>>>
>>> I would like to present a draft RFC for allowing object keys in arrays:
>>> https://wiki.php.net/rfc/object_keys_in_arrays
>> Overall, this is something I always wanted, but adding it means that the
>> type of all array functions returning keys widens, which is quite the BC
>> hell ?
>>
>> The basic assumption is that, when an `array` is given, `foreach ($array as
>> $key => )` produces a `$key` if type `string|int`.
>>
>> While this assumption does not hold true for `iterable` (notably
>> `SplObjectStorage`, `Generator`), it's still quite a jump to break it here,
>> so it would probably require scheduling such a feature for 9.0.
>>
> Definitely disagree here. Your existing code will continue to work fine
> without changes. It is only after passing objects as keys to other
> functions with the assumption above that your code breaks. Sure, this will
> require code changes for frameworks to handle these cases gracefully but it
> won't suddenly break your website that hasn't been touched for years.
>
> Note that even minor PHP versions have historically not followed strict
> semantic versioning. If we did, most PHP features would have to be pushed
> back years given PHPs relatively slow release cycle. I don't think that's
> desirable for neither PHP developers nor maintainers.

I do agree with Marco, lots of generic code manipulating array keys will 
be prone to failure with such feature, it is a breaking change. 
Nevertheless, the feature is so appealing that I'm definitely OK with 
fixing all the things ! Nevertheless, lots of major frameworks and 
libraries will having tests to write, and fixes to do, and the 
transition to support will probably be erratic and slow.

--

Pierre