Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112826
MIME-Version: 1.0
References: <CAEPJdu=kopidV44A01Sjv_eLq_fkLsjVuzqXx+j9b9gCahn2Vg@mail.gmail.com>
In-Reply-To: <CAEPJdu=kopidV44A01Sjv_eLq_fkLsjVuzqXx+j9b9gCahn2Vg@mail.gmail.com>
Date: Sun, 10 Jan 2021 01:48:28 +0000
Message-ID: <CAFPFaMK6LpF=1EoPXrJBJjEKKO7LVKEzw6oExMT_49aRQwoFWQ@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002779be05b881fd8f"
Subject: Re: [PHP-DEV] #[Deprecated] Attribute
From: george.banyard@gmail.com ("G. P. B.")

--0000000000002779be05b881fd8f
Content-Type: text/plain; charset="UTF-8"

On Sat, 19 Dec 2020 at 10:19, Benjamin Eberlei <kontakt@beberlei.de> wrote:

> Hi internals,
>
> I have updated the RFC for a #[Deprecated] attribute that wasn't completed
> for PHP 8.0 due to time constraints and I am able to restart the discussion
> now.
>
> https://wiki.php.net/rfc/deprecated_attribute
>
> The following updates have been made:
>
> - focus on only method and function deprecations for now, removed
> class/property/constant deprecations.
> - a section on explaining the runtime effects of deprecations in PHP, and a
> note that this RFC is about completing deprecation support within the
> existing model, while changes to deprecations in general are out of scope /
> a disjunct concern for a different RFC.
>
> Sara proposed a much improved implementation over my initial patch, by
> using the already existing ZEND_ACC_DEPRECATED constant on userland
> functions. The resulting implementation is therefore much simpler and
> really just extending existing function deprecation support from internal
> to userland functions. You can find the PR here:
>
> https://github.com/php/php-src/pull/6521
>
> Let me know what you think.
>
> greetings
> Benjamin
>

Just to clarify this raises an E_DEPRECATED right?
Could it make sense to raise E_USER_DEPRECATED instead?

Best regards,

George P. Banyard

--0000000000002779be05b881fd8f--