Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112787 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 54802 invoked from network); 6 Jan 2021 19:40:40 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 6 Jan 2021 19:40:40 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id AADC91804A7 for ; Wed, 6 Jan 2021 11:17:11 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 6 Jan 2021 11:17:10 -0800 (PST) Received: by mail-wm1-f42.google.com with SMTP id c133so3280163wme.4 for ; Wed, 06 Jan 2021 11:17:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=craigfrancis.co.uk; s=default; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ok9r/HEqXBd7Sts3fdKNDOt8EEZQCzEP5AK3avwuGxY=; b=e3vtEUlHdrJdu4YVK9+6fMJZbWjjzcx7Y4yHrf8kZ3pfcJvStSmJ4OBRTJCOiOdWMR owuRX677LhFgD+uGKg33bGgWfRrq6gnTBYtmN4WJzvXiTtUe1hiik83uQwTg4PJXOElI w5mO/XNnFTGzgfYOi9rBtEA+DdbJXl3eohKGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ok9r/HEqXBd7Sts3fdKNDOt8EEZQCzEP5AK3avwuGxY=; b=XHxRmrlVP5iLqOZ4fLIRwWffucRFlmezHzI23BtgQqFMMVHNQt5oYoUaxlLXAB/TpB 8IL6DzR8CvWWLRKnDRGwh+Z+jzYKvD/QIA1g8ey+r3IAd3mYbo2Zu/ZD+Fy/jGUCF5fW +hOMbeQMxF3L0QS6jCZu6Gs4/aCjh24L9b1T5yLsIaLAsS6L134hW9op3m7uNfTR+gEc kH9eA0QKktHKYnp+lFyOmPKloUZQlM5iJzlcBfvKJ68fSYgUFezoNWrQt9R/masguVUH NjT3kOM5rXCyjxBijI1NAoBCvJAm/MIHSbOM/6CijTe+Jer5z3+4tMm45nTXX+nil5Ra mU8g== X-Gm-Message-State: AOAM530olG6vNy9feHV8IyPlJVReCfGrCrGEpukmc3ujl0lBPLfjONKU N4kN6vY8dqiM5jm3NO2BjnWuYHy+6jubYy7YyKo7ew== X-Google-Smtp-Source: ABdhPJy2dabZz4Ckd0SrDq1CSnTxRzmrA+GCHuU0s6VMwmuNAxl30bVhG6p8DuAiOGqXZWCXgcx46Z/x6J7H5amaboQ= X-Received: by 2002:a7b:c1c1:: with SMTP id a1mr4906361wmj.104.1609960628630; Wed, 06 Jan 2021 11:17:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Wed, 6 Jan 2021 19:16:57 +0000 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary="0000000000005f7b7705b8402bc9" Subject: Re: [PHP-DEV] ENT_COMPAT for htmlentities and htmlspecialchars From: craig@craigfrancis.co.uk (Craig Francis) --0000000000005f7b7705b8402bc9 Content-Type: text/plain; charset="UTF-8" On Wed, 6 Jan 2021 at 15:46, Nikita Popov wrote: > On Sat, Dec 26, 2020 at 12:03 PM Craig Francis > wrote: > >> Hi, >> >> Could htmlspecialchars() use ENT_QUOTES by default? >> >> [...] > > > I agree that we should switch the default to ENT_QUOTES. I also agree that > we should enable ENT_SUBSTITUTE by default. I don't see any downside to > these two options. > > Would you like to submit a PR? > Thanks Nikita, I've submitted a PR, I think it follows the Coding Standards, and I've got the tests passing, but feel free to edit/delete if it's not right. https://github.com/php/php-src/pull/6583 If this is accepted, I can also look at the documentation updates. Craig --0000000000005f7b7705b8402bc9--