Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112756
MIME-Version: 1.0
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <8aa05350-05fc-df9d-e5d6-fa0f4feb57ba@alec.pl> <fdbc8779-de22-46a1-ab6e-e3cfb34565b4@www.fastmail.com>
 <c3dfee4f-6f54-9b4a-a599-fb016ed6a110@alec.pl> <4eec7448-f7ab-9955-8c2d-68cd4f822535@gmail.com>
 <7d8ce2a2-8d85-4312-af22-da643faa3a7f@www.fastmail.com> <1BC8BF20-B961-4360-855B-5BB95338BB8A@newclarity.net>
 <d07b38e1-78f9-822e-f3be-a4ed42b6702b@fischer.name> <eb92cb31-9c2c-31a6-e352-0f0f84be1a54@gmail.com>
 <30e219c4-bfcb-026f-630e-bda8f21b3787@fischer.name> <642fa510-3dd2-da98-e0cd-3aa83ee2dd90@processus.org>
In-Reply-To: <642fa510-3dd2-da98-e0cd-3aa83ee2dd90@processus.org>
Date: Tue, 5 Jan 2021 09:12:51 +0000
Message-ID: <CAJvSBVPPbZ1Gj+_p4kpJUfZWLMMRj2q_0EAwtw58Y3W_PENF9A@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008a704205b8239e84"
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: phpmailinglists@gmail.com (Peter Bowyer)

--0000000000008a704205b8239e84
Content-Type: text/plain; charset="UTF-8"

On Mon, 4 Jan 2021 at 15:21, Pierre R. <pierre-php@processus.org> wrote:

> I do not agree with having values per default, this is error prone in
> most of my use cases.
>
> In most case where I need enums, I often need to replicate those in
> database too, or in message broker serialized messages: in this context,
> whenever I need to fix a typo in a enum case name, for example, if I use
> default values, I would have errors with my existing database records or
> live messages.
>
> I prefer to keep an explicit switch/match to hydrate values from
> database or elsewhere, and use a value-less enum on the PHP side. Case
> names are the only semantically important value for the developer, and
> your code should not care about having a string value. In most cases
> only exchanges with the outside world in an heterogeneous environment
> (having a database makes it heterogeneous) care about having string
> values. In this case, I highly prefer having explicitely written
> (de)hydration code than automatic magic values happening over the place.
>

I agree.

Peter

--0000000000008a704205b8239e84--