Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112747
To: internals@lists.php.net
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <8aa05350-05fc-df9d-e5d6-fa0f4feb57ba@alec.pl>
 <fdbc8779-de22-46a1-ab6e-e3cfb34565b4@www.fastmail.com>
 <c3dfee4f-6f54-9b4a-a599-fb016ed6a110@alec.pl>
 <4eec7448-f7ab-9955-8c2d-68cd4f822535@gmail.com>
 <7d8ce2a2-8d85-4312-af22-da643faa3a7f@www.fastmail.com>
 <1BC8BF20-B961-4360-855B-5BB95338BB8A@newclarity.net>
 <d07b38e1-78f9-822e-f3be-a4ed42b6702b@fischer.name>
Message-ID: <eb92cb31-9c2c-31a6-e352-0f0f84be1a54@gmail.com>
Date: Mon, 4 Jan 2021 14:05:48 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <d07b38e1-78f9-822e-f3be-a4ed42b6702b@fischer.name>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: rowan.collins@gmail.com (Rowan Tommins)

On 04/01/2021 11:15, Markus Fischer wrote:
> On 03.01.21 12:01, Mike Schinkel wrote:
>> So in my perfect world this:
>>
>> enum BookingStatus {
>>       case PENDING;
>>       case CONFIRMED;
>>       case CANCELLED;
>> }
>>
>> Would be equivalent to:
>>
>> enum BookingStatus {
>>       case PENDING = "PENDING";
>>       case CONFIRMED = "CONFIRMED";
>>       case CANCELLED = "CANCELLED";
>> }
>
> I'm with Mikes' suggesting here, see also my previous messages [1] [2].
>
> I don't know how to back this up with numbers, but the way I see it 
> the majority of use cases will have a benefit of being able to 
> directly use the literal values derived from the lexical ones and the 
> ability to have custom values is feature next to it.


I would personally be OK with this if it was allowed but opt-in, e.g. 
adding the ": string" would default the values in that way, or even 
something magic like ": auto".

I'm still not a fan of having values *always* defined, because I want to 
be able to pick case labels without worrying about whether they make 
sense as values.

For instance, there's a similar maintenance issue to named parameters: 
having a default value means if I write "case PENDING;" in v1.0, I can't 
change that to "case PENDING='P';" or "case PENDING=1;" in v1.1, in case 
somebody is relying on the value being 'PENDING', which was never intended.

Regards,

-- 
Rowan Tommins
[IMSoP]