Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112742
User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396
Mime-Version: 1.0
Message-ID: <76f65313-5f72-43ff-b2ee-84e91acb37dd@www.fastmail.com>
In-Reply-To: <964326f1-a3ba-e343-86a6-ea88c33d45c8@mabe.berlin>
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <67c9d05a-f0a7-fcea-32ea-7a4e409308a1@mabe.berlin>
 <5120eee2-56c4-4608-9e41-4dd05563fef7@www.fastmail.com>
 <ae91f274-96bd-0041-43da-d5eb7a9a8986@mabe.berlin>
 <CAPyj-LAkF_m8ZtnNTsxOSQh3B4zscevp-hmiCU-=1YBK35wcGg@mail.gmail.com>
 <964326f1-a3ba-e343-86a6-ea88c33d45c8@mabe.berlin>
Date: Sun, 03 Jan 2021 21:25:31 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: larry@garfieldtech.com ("Larry Garfield")

On Sun, Jan 3, 2021, at 2:25 PM, Marc wrote:

> >> You already provide a lookup mechanism with `MyEnum::from()` - I don't
> >> see a real use-case for proving a pre build map. The main use case I see
> >> is to list all possible enum values but this doesn't require a map and a
> >> zero-indexed-array would also be more performant with packed arrays
> >> (correct me if I'm wrong).
> > I do somewhat agree with you there. We're essentially returning
> > `Array<UnitEnum>|Map<int|string, ScalarEnum>` which feels
> > inconsistent. When you're calling cases() you're most likely going to
> > loop over it at which point $case->value is available at your
> > disposal.
> 
> Would you consider making `cases()` returning a simple list in all cases 
> instead of differentiate between UnitEnum and ScalarEnum given the fact 
> that mostly people just want to loop over cases and a lookup is already 
> available with ScalarEnum::from() to provide a cleaner interface?
> 
> Marc


Ilija and I talked this one over a bit more, and decided that you're right.  Between ->value and from() we couldn't come up with a use case that would need the assoc array that wouldn't work just as well with ->value, and it makes the method type definition simpler.

I've updated the RFC to have cases() always return a packed array; Ilija will update the PR soon.

Thanks for your feedback!

--Larry Garfield