Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112698
To: internals@lists.php.net
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <8aa05350-05fc-df9d-e5d6-fa0f4feb57ba@alec.pl>
 <fdbc8779-de22-46a1-ab6e-e3cfb34565b4@www.fastmail.com>
 <c3dfee4f-6f54-9b4a-a599-fb016ed6a110@alec.pl>
Message-ID: <4eec7448-f7ab-9955-8c2d-68cd4f822535@gmail.com>
Date: Thu, 31 Dec 2020 12:53:07 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <c3dfee4f-6f54-9b4a-a599-fb016ed6a110@alec.pl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: rowan.collins@gmail.com (Rowan Tommins)

On 30/12/2020 21:24, Aleksander Machniak wrote:
> My argument is that, from an end-user perspective, I don't really see
> why Unit and Scalar enums have to have different "API" at this point.
> I'm talking about ":string"/":int" in the enum definiton as well as
> ->value and ->from().


My personal opinion is that for many enums, explicitly not having a 
scalar representation is a good thing.

This is basically similar to my opinion of __toString() etc: if you have 
*multiple* ways to convert something to/from a scalar, blessing one of 
them as "default" is arbitrary and confusing.

For example:

enum BookingStatus {
      case PENDING;
      case CONFIRMED;
      case CANCELLED;

      public function getId() {
            return match($this) {
                 self::PENDING => 1,
                 self::CONFIRMED => 2,
                 self::CANCELLED => 3,
            };
      }
      public function getCode() {
            return match($this) {
                 self::PENDING => 'PEN',
                 self::CONFIRMED => 'CON',
                 self::CANCELLED => 'CAN',
            };
      }
      public function getEnglishDescription() {
            return match($this) {
                 self::PENDING => 'Pending Payment',
                 self::CONFIRMED => 'Confirmed',
                 self::CANCELLED => 'Cancelled',
            };
      }
}


Regards,

-- 
Rowan Tommins
[IMSoP]