Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112681
User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396
Mime-Version: 1.0
Message-ID: <f3c8e38a-faba-48db-95e2-87f4c19ebe12@www.fastmail.com>
In-Reply-To: <012f426d-ff07-fce7-d642-c64bafa5aaf5@gmail.com>
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <012f426d-ff07-fce7-d642-c64bafa5aaf5@gmail.com>
Date: Wed, 30 Dec 2020 13:47:58 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: larry@garfieldtech.com ("Larry Garfield")

On Wed, Dec 30, 2020, at 6:27 AM, Rowan Tommins wrote:
> On 28/12/2020 20:21, Larry Garfield wrote:
> > After considerable discussion and effort, Ilija and I are ready to o=
ffer you round 2 on enumerations.
>=20
>=20
> Thank you both, again, for all your efforts. I'm pleased to say that I=
=20
> like this draft even more than the last one. :)
>=20
> A couple of points that occurred to me reading through:
>=20
> - The magic methods section lists __call as allowed, but not=20
> __callStatic; was this deliberate, or just an oversight?

More oversight; the reasons for not including it initially aren't really=
 good reasons, so we'll unblock that.

> - Under Future Scope, the "Grouped Syntax" sub-section says "That woul=
d=20
> only work on the simple, non-primitive-backed case with no methods=20
> defined [...] it is unclear how common that will be in practice" This=20=

> caveat doesn't apply to the current proposed syntax, and should perhap=
s=20
> be re-visited.
>=20
> Given that this is currently a legal declaration:
>=20
> class Suit {
>  =C2=A0 const Hearts =3D 'H', Diamonds =3D 'D', Clubs =3D 'C', Spades =
=3D 'S';
> }
>=20
> It seems fairly reasonable for the enum version to allow the same synt=
ax:
>=20
> enum Suit: string {
>  =C2=A0 case Hearts =3D 'H', Diamonds =3D 'D', Clubs =3D 'C', Spades =3D=
 'S';
> }
>=20
> Or, for a non-scalar enum:
>=20
> enum Suit {
>  =C2=A0 case Hearts, Diamonds, Clubs, Spades;
> }

That's partially left over from when we had per-case methods, where grou=
ping would be highly fugly.  However, I'm still advocating for tagged un=
ions (in a future step) having per-case methods, and that would make the=
 grouping syntax fugly again.  It's trivial to add later, so for now I t=
hink it's best to skip.  If we find later on it doesn't get in the way o=
f anything it's an easy addition.

--Larry Garfield