Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112658
To: internals@lists.php.net
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
Message-ID: <012f426d-ff07-fce7-d642-c64bafa5aaf5@gmail.com>
Date: Wed, 30 Dec 2020 12:27:28 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: rowan.collins@gmail.com (Rowan Tommins)

On 28/12/2020 20:21, Larry Garfield wrote:
> After considerable discussion and effort, Ilija and I are ready to offer you round 2 on enumerations.


Thank you both, again, for all your efforts. I'm pleased to say that I 
like this draft even more than the last one. :)

A couple of points that occurred to me reading through:

- The magic methods section lists __call as allowed, but not 
__callStatic; was this deliberate, or just an oversight?

- Under Future Scope, the "Grouped Syntax" sub-section says "That would 
only work on the simple, non-primitive-backed case with no methods 
defined [...] it is unclear how common that will be in practice" This 
caveat doesn't apply to the current proposed syntax, and should perhaps 
be re-visited.

Given that this is currently a legal declaration:

class Suit {
   const Hearts = 'H', Diamonds = 'D', Clubs = 'C', Spades = 'S';
}

It seems fairly reasonable for the enum version to allow the same syntax:

enum Suit: string {
   case Hearts = 'H', Diamonds = 'D', Clubs = 'C', Spades = 'S';
}

Or, for a non-scalar enum:

enum Suit {
   case Hearts, Diamonds, Clubs, Spades;
}


Regards,

-- 
Rowan Tommins
[IMSoP]