Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112629
User-Agent: Cyrus-JMAP/3.3.1-61-gb52c239-fm-20201210.001-gb52c2396
Mime-Version: 1.0
Message-ID: <9b1fdd49-f576-4128-b9b9-c61bf8f58d63@www.fastmail.com>
In-Reply-To: 
 <CAG9XoMQxQ4ywj32M7z7gvrq7iZaiVsC=H3AEyzYO8zZijcntvA@mail.gmail.com>
References: <eadd4a32-a05b-463b-a91f-a5d353c577b2@www.fastmail.com>
 <CAG9XoMQxQ4ywj32M7z7gvrq7iZaiVsC=H3AEyzYO8zZijcntvA@mail.gmail.com>
Date: Mon, 28 Dec 2020 20:37:18 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain
Subject: Re: [PHP-DEV] [RFC] Enumerations, Round 2
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Dec 28, 2020, at 6:40 PM, Benjamin Morel wrote:
> Hi Larry, thank you for the updated RFC!
> I love it, and having played with the implementation, I can say I love it
> so far as well.
> 
> I have one suggestion regarding reflection:
> Shouldn't ReflectionCase expose an additional getInstance() method, that
> would return the case instance, such as Suit::HEARTS?

I... thought we had that in there.  Did I remove the wrong method?  I know it's in there somewhere.  Let me double check with Ilija on what it's supposed to be called.  Will update when that's sorted out.

> Also, I noticed 2 typos in the code samples:
> 
> - in "Enumerated Methods", 1st code block: missing "implements Colorful"
> after "enum Suit"
> - in "Enumerated Methods", 2nd code block: missing "public function
> color()" after "private function __construct() {}"

Both fixed, thanks.

> Finally, I got a segmentation fault while trying to use what I think is an
> unsupported syntax (removing the ":string" from a scalar enum), where is
> the correct place to report this? The GitHub PR?

On the PR, please.  Sounds like we need a few more negative tests to make sure it fails gracefully.

--Larry Garfield