Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112557
To: internals@lists.php.net
References: <CAEPJdukymFyBCPKUTVeDQcT3p32O58ko4PNAVwmhB3SODDyxog@mail.gmail.com>
Message-ID: <f9bbd68e-a989-f9bb-102b-9b5839fc2829@gmail.com>
Date: Sat, 19 Dec 2020 19:27:15 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <CAEPJdukymFyBCPKUTVeDQcT3p32O58ko4PNAVwmhB3SODDyxog@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Subject: Re: [PHP-DEV] [RFC] #[NamedParameterAlias] Attribute
From: rowan.collins@gmail.com (Rowan Tommins)

On 19/12/2020 11:28, Benjamin Eberlei wrote:
> This is my take on parameter names now being public API, at its future
> potential for code maintenance, refactoring and backwards compatibility.
>
> https://wiki.php.net/rfc/named_parameter_alias_attribute


Hi Benjamin,

This sounds like a sensible feature. The suggested name seems a bit 
long, but I'm not quite sure what to replace it with.

It just occurred to me that there's a potential connection, in concept 
if not implementation, with the #[Deprecated] RFC you also just posted: 
parameter name aliases may well be used to provide a limited-time 
transition mechanism rather than a permanent feature, so it might be 
useful to allow them to be marked as deprecated.

e.g.

// Version 1.0: parameter name is misspelled
function doSomething(bool $formatNumters) { ... }

// Version 1.1: parameter name changed, old name added as a deprecated alias
// if the misspelled name is used, an E_DEPRECATED is raised
function doSomething(#[ParameterNameAlias('formatNumters', deprecated: 
true)] $formatNumbers) { ... }

// Version 2.0: alias removed; the misspelled name is now an error
function doSomething(#[ParameterNameAlias($formatNumbers) { ... }


Regards,

-- 
Rowan Tommins
[IMSoP]