Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11252 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 64364 invoked by uid 1010); 15 Jul 2004 10:08:38 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 64340 invoked from network); 15 Jul 2004 10:08:37 -0000 Received: from unknown (HELO out2.smtp.messagingengine.com) (66.111.4.26) by pb1.pair.com with SMTP; 15 Jul 2004 10:08:37 -0000 Received: from server3.messagingengine.com (server3.internal [10.202.2.134]) by mail.messagingengine.com (Postfix) with ESMTP id F1A20C11C42; Thu, 15 Jul 2004 06:08:36 -0400 (EDT) Received: by server3.messagingengine.com (Postfix, from userid 99) id 1069716113B; Thu, 15 Jul 2004 06:08:38 -0400 (EDT) Content-Disposition: inline Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 X-Mailer: MIME::Lite 1.4 (F2.72; T1.001; A1.62; B3.01; Q3.01) Cc: internals@lists.php.net References: <1089817928.30144.200349852@webmail.messagingengine.com> <1089872437.29414.200401086@webmail.messagingengine.com> In-Reply-To: To: "Derick Rethans" Date: Thu, 15 Jul 2004 03:08:38 -0700 X-Sasl-Enc: lrxr3UZjQdzGP0FLudzGvg 1089886118 Message-ID: <1089886118.18783.200410342@webmail.messagingengine.com> Subject: Re: [PHP-DEV] Info needed From: kameshj@fastmail.fm ("Kamesh Jayachandran") Hi Derick, Can you guide me how to produce the patch? I thought 'diff -u newsource oldsource ' will give the patch. Is it other way round? I will lokk into white space issue. With regards Kamesh Jayachandran On Thu, 15 Jul 2004 12:00:11 +0200 (CEST), "Derick Rethans" said: > On Wed, 14 Jul 2004, Kamesh Jayachandran wrote: > > > Hi Derick, > > Thanks for responding. > > I am posting my patches module by module. > > For zend you can find the patches at the following locations. > > http://puggy.symonds.net/~kameshj/zendnetwarepatches.tar.gz > > 1. This patch is the wrong way around (you swapped old and new in the > diff command). > > 2. Tons of whitespace is introduced (bad idea to mix with code changes) > > 3. I think you screwed up line ending problems, all our code has Unix > style line endinds. > > other than that it looks okay, though I'm not sure if we need too those > really long comments in the code. > > regards, > Derick