Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112518
To: internals@lists.php.net
References: <b6e84a3b-012e-4ef3-8c2b-14c7fcf2d45d@www.fastmail.com>
 <5f138466-1da4-0048-3cba-13c0d2da5732@gmx.net>
 <CAESVnVp6hGk6NAJv55APhtXc4cBHDbp8Z182=is8EZeZKBJzww@mail.gmail.com>
Message-ID: <0956d65c-91ed-1d99-4b93-ce6ced83e9b7@gmx.net>
Date: Tue, 15 Dec 2020 20:37:25 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVp6hGk6NAJv55APhtXc4cBHDbp8Z182=is8EZeZKBJzww@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Content-Language: en-US
Subject: Re: [PHP-DEV] [RFC] Short-match
From: a.leathley@gmx.net (Andreas Leathley)

On 15.12.20 20:08, Sara Golemon wrote:
> Or even better with existing syntax:
> ```php
> $this->handler =3D match($var) {
>    null, true, false =3D> json_encode($var),
>    default =3D> \is_string($var) ? "\"$var\"" : \rtrim(\print_r($var, tr=
ue)),
> };
>
> I appreciate that this is a specific counter-example to your example, bu=
t
> you picked the bad example. :p

Sure, for this specific example - there are of course longer real-life
examples (sometimes even nested ones), often using instanceof, is_array,
is_callable and similar constructs, but they seem a bit too much for a
discussion. If you add slightly more logic then it might be better:

```php
$this->handler =3D function ($var): string {
 =C2=A0=C2=A0=C2=A0=C2=A0 return match {
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 null =3D=3D=3D $var =3D>=
 'null',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 true =3D=3D=3D $var =3D>=
 'true',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 false =3D=3D=3D $var =3D=
> 'false',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 is_string($var) =3D> '"'=
.$var.'"',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 is_callable($var) =3D> '=
callable',
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 is_object($var) =3D> get=
_class($var),
 =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 default =3D> rtrim(print=
_r($var, true)),
 =C2=A0=C2=A0=C2=A0=C2=A0 };
};
```

I guess that would be an advantage of these current switch(true) (and
possibly future match {}) statements: it is easy to add additional
matches that do not impact the others.

I do like Nikitas idea to make it a TypeError for non-bool matches.