Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112513
MIME-Version: 1.0
References: <b6e84a3b-012e-4ef3-8c2b-14c7fcf2d45d@www.fastmail.com>
In-Reply-To: <b6e84a3b-012e-4ef3-8c2b-14c7fcf2d45d@www.fastmail.com>
Date: Tue, 15 Dec 2020 10:00:40 +0100
Message-ID: <CAF+90c-WLa9V17ahpipY86vqMWWcG2K3znHuk6oAVkXAN000+Q@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002a5c1205b67cff17"
Subject: Re: [PHP-DEV] [RFC] Short-match
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000002a5c1205b67cff17
Content-Type: text/plain; charset="UTF-8"

On Mon, Dec 14, 2020 at 6:34 PM Larry Garfield <larry@garfieldtech.com>
wrote:

> I present to Internals this tiny RFC to follow up on the match()
> expression RFC from earlier in the year.  There was solidly positive
> support for this shortcut previously but it was removed for simplicity at
> the time, with the intent to bring it back later.  It's now later.
>
> https://wiki.php.net/rfc/short-match
>
> --
>   Larry Garfield
>   larry@garfieldtech.com
>

Just like Sara, I'm not strongly opposed to this, but I'm also not sure
this is worthwhile. Writing "match (true) {" instead of "match {" is not
particularly tedious when compared to the size of the remaining structure.
Writing "match (true) {" has the advantage of being more explicit about
what this actually does, namely a "true ===" comparison. If it is omitted,
a reasonable person might think that

    match {
        preg_match(...) => ...
    }

is going to do something sensible, like it would if placed inside an
"if()". But it does not, as preg_match() returns 1, not true, and as such
the match arm will never be taken. This is more obvious when the value that
is being compared against is explicitly given.

Of course, with "match {" being a dedicated syntax, we could make it a
TypeError to use a non-bool match arm...

Regards,
Nikita

--0000000000002a5c1205b67cff17--