Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112508
MIME-Version: 1.0
References: <b6e84a3b-012e-4ef3-8c2b-14c7fcf2d45d@www.fastmail.com>
 <CADyq6s+pe0NDvL22HTCinAcCFNxJc6ZozMRn_b0mhJT15tPPxA@mail.gmail.com>
 <CAEiu4gzw8Q__VZADPbacNz4N4ccoqEvJVfqr37s0+FKZPVo05A@mail.gmail.com> <CAESVnVq2w0omVEiSCj5gY=i5mmrZr5D16DZtjPc1OZGNbyJYug@mail.gmail.com>
In-Reply-To: <CAESVnVq2w0omVEiSCj5gY=i5mmrZr5D16DZtjPc1OZGNbyJYug@mail.gmail.com>
Date: Mon, 14 Dec 2020 15:12:38 -0800
Message-ID: <CAN2symjxsX44Kryk7t1xtOfSfCdHw_26D_Ez7ToDAcozdSxCpA@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Doug Nelson <dougnelson@silktide.com>, Marco Pivetta <ocramius@gmail.com>, 
	Larry Garfield <larry@garfieldtech.com>, php internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Short-match
From: paul.crovella@gmail.com (Paul Crovella)

On Mon, Dec 14, 2020 at 1:23 PM Sara Golemon <pollita@php.net> wrote:
>
> On Mon, Dec 14, 2020 at 2:24 PM Doug Nelson <dougnelson@silktide.com> wrote:
>
> > Both you and Sara at different points have talked about thinking was bad
> > practice, but I've not read anything compelling about why it should be
> > considered as such.
> >
> >
> I'm not a full -1 on the concept (especially as match(true) has the
> convenience of returning a value), but it's very square peg in a round hole
> to me.
>
> At the end of the day though, that's a style choice and not one I have any
> business imposing on anyone, and certainly within the context of this diff,
> the actual change is trivial.  It's sugar for match(true) that looks like
> match.  /shrug
>
> I might suggest broadening the scope to include `switch` as well though.
> If we're going to codify match(true) as a pattern, we should at least be
> consistent about it.
>
> -Sara

I lean more on the side of +1 but otherwise agree with Sara here. I'm
apathetic on including switch but it's worth considering.

If this (slightly) better aligns someone's code with how they're
thinking about the problem then yay.