Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:11250 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 40621 invoked by uid 1010); 15 Jul 2004 10:00:16 -0000 Delivered-To: ezmlm-scan-internals@lists.php.net Delivered-To: ezmlm-internals@lists.php.net Received: (qmail 40588 invoked from network); 15 Jul 2004 10:00:16 -0000 Received: from unknown (HELO jdi.jdimedia.nl) (212.204.192.51) by pb1.pair.com with SMTP; 15 Jul 2004 10:00:16 -0000 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i6FA0Fm6032015 for ; Thu, 15 Jul 2004 12:00:15 +0200 Received: from localhost (localhost [127.0.0.1]) by jdi.jdimedia.nl (8.12.11/8.12.11) with ESMTP id i6FA0Abd031990; Thu, 15 Jul 2004 12:00:10 +0200 Date: Thu, 15 Jul 2004 12:00:11 +0200 (CEST) X-X-Sender: derick@localhost To: Kamesh Jayachandran cc: internals@lists.php.net In-Reply-To: <1089872437.29414.200401086@webmail.messagingengine.com> Message-ID: References: <1089817928.30144.200349852@webmail.messagingengine.com> <1089872437.29414.200401086@webmail.messagingengine.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Virus-Scanned: by amavisd-new at jdimedia.nl Subject: Re: [PHP-DEV] Info needed From: derick@php.net (Derick Rethans) On Wed, 14 Jul 2004, Kamesh Jayachandran wrote: > Hi Derick, > Thanks for responding. > I am posting my patches module by module. > For zend you can find the patches at the following locations. > http://puggy.symonds.net/~kameshj/zendnetwarepatches.tar.gz 1. This patch is the wrong way around (you swapped old and new in the diff command). 2. Tons of whitespace is introduced (bad idea to mix with code changes) 3. I think you screwed up line ending problems, all our code has Unix style line endinds. other than that it looks okay, though I'm not sure if we need too those really long comments in the code. regards, Derick