Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:1125 Return-Path: Mailing-List: contact internals-help@lists.php.net; run by ezmlm Delivered-To: mailing list internals@lists.php.net Received: (qmail 18790 invoked from network); 1 May 2003 11:14:10 -0000 Received: from unknown (HELO secure.thebrainroom.com) (213.239.42.171) by pb1.pair.com with SMTP; 1 May 2003 11:14:10 -0000 Received: from zaneeb.brainnet.i (brain.dial.nildram.co.uk [195.149.29.154]) by secure.thebrainroom.com (8.9.3/8.9.3) with ESMTP id MAA30357; Thu, 1 May 2003 12:14:09 +0100 Received: from zaneeb.brainnet.i (IDENT:Tb/2wE4rVvg/1BFASkcly+SIRWkxhwgf@zaneeb.brainnet.i [127.0.0.1]) by zaneeb.brainnet.i (8.11.6/8.11.6) with ESMTP id h41BE9829472; Thu, 1 May 2003 12:14:09 +0100 Date: Thu, 1 May 2003 12:14:09 +0100 (BST) X-X-Sender: wez@zaneeb.brainnet.i To: Masaki Fujimoto cc: internals@lists.php.net In-Reply-To: <200305011054.h41AsQ811798@bass.serverhost.net> Message-ID: References: <200305011054.h41AsQ811798@bass.serverhost.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: stream_set_write_buffer() does not work From: wez@thebrainroom.com (Wez Furlong) I am aware of this issue, however, reverting leaves us at the mercy of problems on solaris. I do plan to implement a write buffer, however, introducing that into the 4.3.x branch is probably a bad idea at this late stage. While I don't think that stream_set_write_buffer()/set_file_buffer() having no effect is such a bad thing (most php scripts don't have any need to call this function), I am concerned about the overall performance of writes in the absence of a user-space write buffer. So I'm looking into a solution at the moment; there is no need to update the documentation at this point. --Wez. On Thu, 1 May 2003, Masaki Fujimoto wrote: > Hello, > > I noticed that stream_set_write_buffer() is no more available on local files > because of the change made on 2003/03/18 to main/streams.c (1.125.2.41 -> > 1.125.2.42: use a file descriptor instead of a file pointer). > > As a result of this change, of course stream_set_write_buffer() and > set_file_buffer() does not work anymore in most of the cases because user-level > I/O buffer functions like setvbuf() does not work on file descriptors, though > I'm not sure if this is the "probelm" or not. > > If this is an intentional result, fixing documents (== add note like "stream_set > _write_buffer does not work on local files, bla bla bla" and fix a sample code) > will do, but if not, maybe we should implement php-level I/O buffer or revert > this change (I'm not sure reverting this change makes another problem, > though:) > > Regards, > > Masaki Fujimoto > fujimoto@tunebiz.net > fujimoto@php.net > > >