Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112491
To: =?Windows-1252?B?gJYglGuUaw==?= <chopins.xiao@gmail.com>,
	"internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: [rfc:direct-execution-opcode] Whether  need __FILE__ the value
 of the file to replace the compiled opcode file path
Thread-Index: AQHWzvEcAaUueSZyfk+A4CVUd1pPoKnzndTr
Date: Sat, 12 Dec 2020 16:50:49 +0000
Message-ID:
 <DM6PR07MB6618C71476476CC20E148182F9C90@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <ME2P282MB0227A4CC422A815336E8B58AF2CB0@ME2P282MB0227.AUSP282.PROD.OUTLOOK.COM>
In-Reply-To:
 <ME2P282MB0227A4CC422A815336E8B58AF2CB0@ME2P282MB0227.AUSP282.PROD.OUTLOOK.COM>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [LBADAyDYHmKqoT3l3Sc0qEvfYC4hoHUru3iV2whA94vTEkuwANlEm03qh4mSIsO9]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: bd4a1705-2523-4be4-d2fc-08d89ebe1492
x-ms-traffictypediagnostic: BN7NAM10HT227:
x-ms-exchange-minimumurldomainage: externals.io#1623
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 PhQOuoC+2rZmOJy8TYcwEuvubLZlGXx9ihSibD4XxG78blxaQq82xxY7+jIaDjTst115kfEtcilCrLUQ9ZJDnE5ZDrgSYZwZIKyniXu/HKzFcuVtl1JcRntO6Q5K5ahlr+omswUyG//A7nBqOGv4Pt3pnlF8KKuvzMu+BFM+TwYQ3fDiCscE92sF+5ioC3jGeAhtsdnMuKOegxsKQ8k4ROMZ3o2Gf/Dfzq0U7zDCtyvUilW1EuPNq1IQYylyhrN5
x-ms-exchange-antispam-messagedata:
 TULhz25H7Xi80jVyNfJo1PQm/ORsqVFo2XOhVCAA2guHOynAQMcZZQaUO6NMMFPr28HBaUjGTjqySNkNfFA4qAxUn/MHje/kqoklqOEw4uCyrgxPXNTVbjxKkyw9wgUT22wsOOm3QLUHoOohYMHRJaiWzK84UE1YYI4I+GTswnYw41HNYLZVbB8g282V8idp1blXF1RyVi3ZjfPc3cB+qg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="Windows-1252"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT039.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: bd4a1705-2523-4be4-d2fc-08d89ebe1492
X-MS-Exchange-CrossTenant-originalarrivaltime: 12 Dec 2020 16:50:49.7537
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT227
Subject: Re: [rfc:direct-execution-opcode] Whether  need __FILE__ the value of
 the file to replace the compiled opcode file path
From: tysonandre775@hotmail.com (tyson andre)

Hi=A0Chopins Xiao,=0A=
=0A=
Some comments on https://wiki.php.net/rfc/direct-execution-opcode=0A=
=0A=
1) This should be marked as "Status: Under Discussion" in the RFC document =
itself, not draft?=0A=
2) https://wiki.php.net/rfc/howto states:=0A=
=0A=
> 5. Listen to the feedback, and try to answer/resolve all questions.=0A=
>    **Update your RFC to document all the issues and discussions.=0A=
>    Cover both the positive and negative arguments.** Put the RFC URL into=
 all your replies.=0A=
=0A=
The RFC guidelines mention this should document the negative arguments,=0A=
e.g. as a Discussion section with quotes of the negative arguments (argumen=
ts against the RFC)=0A=
and positive arguments.=0A=
=0A=
I'd recommend linking to the discussions on the mailing list, as there had =
been a lot of discussion there,=0A=
e.g. as a References section at the end of the document=0A=
https://externals.io/message/112482 and  https://externals.io/message/11196=
5 and https://externals.io/message/111979=0A=
=0A=
----=0A=
=0A=
https://wiki.php.net/rfc/direct-execution-opcode#backward_incompatible_chan=
ges was also unclear to me=0A=
=0A=
> Magic constant `__FILE__` is the absolute path to the compiled source fil=
e, not the path to the opcode file that is currently executing=0A=
=0A=
"to the compiled source file" should be clarified to say something like "to=
 the compiled source file for the packager (not the end user)"=0A=
=0A=
(e.g. `require_once __DIR__ . '/other.php'` would get converted to the opco=
de `INCLUDE_OR_EVAL (require_once) string("/home/packagerusername/other.php=
")`=0A=
even with optimizations disabled, which would be unexpected for the package=
r and the end user)=0A=
=0A=
I don't think there are any problems with `__LINE__`, that's the line numbe=
r within the file, and is unchanged by the path to the file.=0A=
=0A=
Regards,=0A=
- Tyson=