Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112474
Message-ID: <BF694206-BACE-4790-B3A6-4B98C45EDB8E@newclarity.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_1A370509-6EE8-4081-90AC-53C7172D457A"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Wed, 9 Dec 2020 12:58:11 -0500
In-Reply-To: <8D795AF6-5C6B-4BB4-A773-6A7BB04503CF@cschneid.com>
Cc: PHP internals <internals@lists.php.net>
To: Christian Schneider <cschneid@cschneid.com>
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
 <CA1EE0E0-E451-427A-9BE8-C84A8E5523DD@newclarity.net>
 <8D795AF6-5C6B-4BB4-A773-6A7BB04503CF@cschneid.com>
Subject: Re: [PHP-DEV] PHP 8 is_file/is_dir input handling
From: mike@newclarity.net (Mike Schinkel)

--Apple-Mail=_1A370509-6EE8-4081-90AC-53C7172D457A
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii



> On Dec 8, 2020, at 11:27 AM, Christian Schneider =
<cschneid@cschneid.com> wrote:
>=20
> Am 08.12.2020 um 17:16 schrieb Mike Schinkel <mike@newclarity.net =
<mailto:mike@newclarity.net>>:
>> 1. Please consider making is_file() return false for an embedded \0 =
and no longer throw an exception or generate a warning.
>=20
> The PR implementing this has already been merged for inclusion in PHP =
8.0.1: https://github.com/php/php-src/pull/6478 =
<https://github.com/php/php-src/pull/6478>
Thanks.

>=20
>> 2. Beyond is_file(), please consider allowing PHP to support both =
types of error handling strategies without forcing complexity just to =
use the 2nd strategy.
>=20
>=20
> This is a contentious topic

Exactly.

> and will have to be handled on a case by case basis I guess.

Which is really all I was asking for; that it be considered on a =
case-by-case basis instead of just assuming that exceptions are always =
preferable.


> E.g. for security-related stuff a fail-early-strategy throwing an =
exception might be preferable, for basic lower-level functions like =
is_file() returning false was chosen to be preferable.
> There is no silver bullet for all cases and having a global switch =
would only make things worse.

-Mike=

--Apple-Mail=_1A370509-6EE8-4081-90AC-53C7172D457A--