Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112456
User-Agent: Cyrus-JMAP/3.3.0-622-g4a97c0b-fm-20201115.001-g4a97c0b3
Mime-Version: 1.0
Message-ID: <244f66fb-81c3-4cf7-a0b5-0a3233e3b9e1@www.fastmail.com>
In-Reply-To: 
 <CABdc3WqwsaMiZAzbfmJFh+3VW981kec_Kz+Ldq9a+yipn48ePQ@mail.gmail.com>
References: <d1c4689e-9120-4e90-837c-a1b3eac63cd6@www.fastmail.com>
 <CABdc3WqwsaMiZAzbfmJFh+3VW981kec_Kz+Ldq9a+yipn48ePQ@mail.gmail.com>
Date: Mon, 07 Dec 2020 09:26:36 -0600
To: "php internals" <internals@lists.php.net>
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] [RFC] Enumerations
From: larry@garfieldtech.com ("Larry Garfield")

On Mon, Dec 7, 2020, at 2:46 AM, Micha=C5=82 Marcin Brzuchalski wrote:
> Hi Larry,
>=20

> Thanks for taking the topic. I love it.
>=20
> Regarding the `::cases()` method on UnitEnum I guess it'd be more natu=
ral
> to cast enum into an array like:
>=20
> (array) Suit;
>=20
> but I realize it'd be harder to implement. The question is if it was e=
ven
> considered?
>=20
> Regarding the `::from()` method responsible for casting was a natural =
cast
> operator considered instead?
> For eg.
> $suit =3D (Suit) $record['suit'];
> Instead of:
> $suit =3D Suit::from($record['suit']);
>=20
> Cheers,
> Micha=C5=82 Marcin Brzuchalski

We didn't really get into explicit casting, since it's so rarely used in=
 conventional PHP code these days.  I'm not sure off hand if supporting =
(Suit)"H" or (string)Suit::Hearts would be easy or hard.  That would be =
an Ilija question.

Assuming it's feasible to do, what do people feel about supporting that?=
  IMO, cases(), from(), and values() need to be kept no matter what as t=
hey're more self documenting and can be passed around as callables.  So =
the question is just whether we should also try to add casting as an ali=
as to those operations.

--Larry Garfield