Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112450
MIME-Version: 1.0
References: <d1c4689e-9120-4e90-837c-a1b3eac63cd6@www.fastmail.com>
In-Reply-To: <d1c4689e-9120-4e90-837c-a1b3eac63cd6@www.fastmail.com>
Date: Mon, 7 Dec 2020 09:46:01 +0100
Message-ID: <CABdc3WqwsaMiZAzbfmJFh+3VW981kec_Kz+Ldq9a+yipn48ePQ@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bda20505b5dbdb7c"
Subject: Re: [PHP-DEV] [RFC] Enumerations
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--000000000000bda20505b5dbdb7c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Larry,

sob., 5 gru 2020 o 00:25 Larry Garfield <larry@garfieldtech.com> napisa=C5=
=82(a):

> Greetings, denizens of Internals!
>
> Ilija Tovilo and I have been working for the last few months on adding
> support for enumerations and algebraic data types to PHP.  This is a
> not-small task, so we've broken it up into several stages.  The first
> stage, unit enumerations, are just about ready for public review and
> discussion.
>
> The overarching plan (for context, NOT the thing to comment on right now)
> is here: https://wiki.php.net/rfc/adts
>
> The first step, for unit enumerations, is here:
>
> https://wiki.php.net/rfc/enumerations
>
> There's still a few bits we're sorting out and the implementation is
> mostly done, but not 100% complete.  Still, it's far enough along to star=
t
> a discussion on and get broader feedback on the outstanding nits.
>
> I should note that while the design has been collaborative, credit for th=
e
> implementation goes entirely to Ilija.  Blame for any typos in the RFC
> itself go entirely to me.
>
> *dons flame-retardant suit*
>

Thanks for taking the topic. I love it.

Regarding the `::cases()` method on UnitEnum I guess it'd be more natural
to cast enum into an array like:

(array) Suit;

but I realize it'd be harder to implement. The question is if it was even
considered?

Regarding the `::from()` method responsible for casting was a natural cast
operator considered instead?
For eg.
$suit =3D (Suit) $record['suit'];
Instead of:
$suit =3D Suit::from($record['suit']);

Cheers,
Micha=C5=82 Marcin Brzuchalski

--000000000000bda20505b5dbdb7c--