Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112430
To: Larry Garfield <larry@garfieldtech.com>, php internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] Enumerations
Thread-Index: AQHWypS0dp+yj+uVBEGwghKNxSJW26nojqKAgAANDgCAABBAdA==
Date: Sat, 5 Dec 2020 16:15:32 +0000
Message-ID:
 <DM6PR07MB6618A1118075A62B9714D96BF9F00@DM6PR07MB6618.namprd07.prod.outlook.com>
References: <d1c4689e-9120-4e90-837c-a1b3eac63cd6@www.fastmail.com>
 <CA46B60F-AF67-4706-8D66-E14A64739A99@mabe.berlin>,<f58c2a28-d603-4eb7-8fe5-aa5cfec47382@www.fastmail.com>
In-Reply-To: <f58c2a28-d603-4eb7-8fe5-aa5cfec47382@www.fastmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [okQ3pogTzT3pIjZsULCgbdlqibImxSXbNDYga5Qe9c72DuaScp6ro6FqHej70e1Y]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: d5c1c933-b33e-4492-68dc-08d89938fd9a
x-ms-traffictypediagnostic: SN1NAM02HT160:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 RMreDdIWyMiEwNaN0zQT9GX0PwxHx4AN1b7rxlDDaULsvu34CJ0T79kjcRQjcaGg6M0UcbYmegLpDjYSlZHyyOmRpBDwTJ8Rs6JiR0W+I/p4mq9VkqKMWMPvYcVKVeM/cSeLp9w6frNvcXiAUZXJra3kC73V7FBrdteCZTJRWJqF+gab8paAdSUMeosnvlRjiKhXqrph3EsDH1SHEAZVdUsOM5sVMYXI47voP5WXVl7b3thNo0lVxhNQqUF0UZSD
x-ms-exchange-antispam-messagedata:
 XFmFFjkWKKn0joY1H7dBlrr158zNmJRW8Vtn8FDiQXrtOr5zcIZLtyRVJke0xRxvCjYtEW1AE8WHJbqpI4mRDqNtpH5fG6hZG/fRU7gAHLIljRXjIQCKYBfElz/8D6yY6sVseapzBLQJo7uMO1zp0Vr0+MoyNQXEA416Wb2mpA/zhwGVbQOKauNirp1GHiB+tt5MWa4hYUMFxcMiB9+DDQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM02FT030.eop-nam02.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: d5c1c933-b33e-4492-68dc-08d89938fd9a
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Dec 2020 16:15:32.4218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM02HT160
Subject: Re: [PHP-DEV] [RFC] Enumerations
From: tysonandre775@hotmail.com (tyson andre)

Hi Larry Garfield,=0A=
=0A=
> Right now they'd do the same as objects, so they'd serialize as an object=
.=0A=
> Unserializing like that, though... hm, that would probably NOT still be =
=3D=3D=3D due to the way PHP handles objects.=0A=
> That's probably undesireable, but I'm not sure at the moment the best way=
 around that.=A0 I'll have to discuss with Iliya.=0A=
=0A=
At a glance, it seems like it's doable in php 8.1 internals to make the uns=
erializer return a singleton if you override the C `unserialize` callback o=
f the class (this could introduce edge cases during unserialization failure=
 for destruction, expected to be solvable).=0A=
This would require using the `C:` serialize() encoding (php uses that for c=
lasses implementing Serializable), not `o:`=0A=
(unserialize can be set to a generic C function that creates a value and pu=
ts it in `*object*`)=0A=
=0A=
```=0A=
// Zend/zend.h=0A=
struct _zend_class_entry {=0A=
	/* .... serializer callbacks */=0A=
	int (*serialize)(zval *object, unsigned char **buffer, size_t *buf_len, ze=
nd_serialize_data *data);=0A=
	int (*unserialize)(zval *object, zend_class_entry *ce, const unsigned char=
 *buf, size_t buf_len, zend_unserialize_data *data);=0A=
=0A=
// ext/standard/var_unserializer.c, in object_custom()=0A=
	if (ce->unserialize =3D=3D NULL) {=0A=
		zend_error(E_WARNING, "Class %s has no unserializer", ZSTR_VAL(ce->name))=
;=0A=
		object_init_ex(rval, ce);=0A=
	} else if (ce->unserialize(rval, ce, (const unsigned char*)*p, datalen, (z=
end_unserialize_data *)var_hash) !=3D SUCCESS) {=0A=
		return 0;=0A=
	}=0A=
```=0A=
=0A=
(I'm one of the maintainers of https://pecl.php.net/package/igbinary , an a=
lternative binary php serializer)=0A=
=0A=
- Tyson=