Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112414
To: Aimeos | Norbert Sendetzky <norbert@aimeos.com>,
 PHP internals <internals@lists.php.net>
References: <d2ae0e40-0ec9-1869-9f64-3f1920324bb2@aimeos.com>
 <186914ae-b5e8-382e-8766-58b45543b52d@gmx.de>
 <eeeb5bdf-8f94-eeac-bbae-7f6c2a3316b4@aimeos.com>
Message-ID: <e4cf2be1-79fa-c9bc-e342-0f144fc33847@gmx.de>
Date: Fri, 4 Dec 2020 13:48:21 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <eeeb5bdf-8f94-eeac-bbae-7f6c2a3316b4@aimeos.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Pass file handle in XMLReader
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 04.12.2020 at 13:35, Aimeos | Norbert Sendetzky wrote:

> Am 04.12.20 um 13:23 schrieb Christoph M. Becker:
>
>> For clarity, it might be preferable to introduce a new static creation
>> method for this.  The implementation could probably use
>> xmlReaderForIO()[1], instead of xmlReaderForFile().
>
> Wouldn't xmlReaderForFd() be more suitable or is this only for file
> handles, not for streams?

xmlReaderForFd() is only for file descriptors; PHP streams are more genera=
l.

> What would be a good name for the new method? XMLReader::stream()?

Maybe XMLReader::createForStream(), but I think the name is secondary;
someone would have to come up at least with a draft implementation first.

Regards,
Christoph