Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112413 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 56279 invoked from network); 4 Dec 2020 13:07:44 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 4 Dec 2020 13:07:44 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 0592D180540 for ; Fri, 4 Dec 2020 04:35:55 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from dd46610.kasserver.com (dd46610.kasserver.com [85.13.163.220]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 4 Dec 2020 04:35:53 -0800 (PST) Received: from [192.168.178.23] (dynamic-077-008-227-073.77.8.pool.telefonica.de [77.8.227.73]) by dd46610.kasserver.com (Postfix) with ESMTPSA id 462D85F86CAF; Fri, 4 Dec 2020 13:35:52 +0100 (CET) To: "Christoph M. Becker" , PHP internals References: <186914ae-b5e8-382e-8766-58b45543b52d@gmx.de> Organization: Aimeos GmbH Message-ID: Date: Fri, 4 Dec 2020 13:35:51 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <186914ae-b5e8-382e-8766-58b45543b52d@gmx.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: Pass file handle in XMLReader From: norbert@aimeos.com (Aimeos | Norbert Sendetzky) Am 04.12.20 um 13:23 schrieb Christoph M. Becker: > For clarity, it might be preferable to introduce a new static creation > method for this. The implementation could probably use > xmlReaderForIO()[1], instead of xmlReaderForFile(). Wouldn't xmlReaderForFd() be more suitable or is this only for file handles, not for streams? What would be a good name for the new method? XMLReader::stream()? Best, Norbert