Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112412
To: Aimeos | Norbert Sendetzky <norbert@aimeos.com>,
 PHP internals <internals@lists.php.net>
References: <d2ae0e40-0ec9-1869-9f64-3f1920324bb2@aimeos.com>
Message-ID: <186914ae-b5e8-382e-8766-58b45543b52d@gmx.de>
Date: Fri, 4 Dec 2020 13:23:39 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <d2ae0e40-0ec9-1869-9f64-3f1920324bb2@aimeos.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Pass file handle in XMLReader
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 02.12.2020 at 18:17, Aimeos | Norbert Sendetzky wrote:

> The XMLReader object only allows a file name in the constructor and the
> open() method. While this is OK most of the time, files stored at cloud
> services not accessible via an URL must be downloaded first. For big
> files (e.g 100MB to 1GB and more), this requires a lot of time and
> resources.
>
> If the XMLReader would be able accept a file handle too, we could pass
> the handle of a stream to the methods and the XMLReader could process
> the XML data on the fly without the need of a local copy.
>
> Is it possible to allow a file handle in the existing methods or is a
> new one required due to type or other constraints like implementation
> difficulties?
>
> The open() method is implemented here:
>
> https://github.com/php/php-src/blob/faea5ab837ab6393c8821f85cf8abe272359=
3e8e/ext/xmlreader/php_xmlreader.c#L835-L887

For clarity, it might be preferable to introduce a new static creation
method for this.  The implementation could probably use
xmlReaderForIO()[1], instead of xmlReaderForFile().

[1]
<http://www.xmlsoft.org/html/libxml-xmlreader.html#xmlReaderForIOhttp://ww=
w.xmlsoft.org/html/libxml-xmlreader.html#xmlReaderForIO

Regards,
Christoph