Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112411
MIME-Version: 1.0
References: <CAF+90c9XgSiD+nOzq6vk2AvoOHWf52GbWdwftVprhr5hxcQkBw@mail.gmail.com>
 <CAOWwgpmFoRyVx9GRYp3ryi0eLiGVH5xT_tYDQY=8LfdE6rdxuw@mail.gmail.com>
In-Reply-To: <CAOWwgpmFoRyVx9GRYp3ryi0eLiGVH5xT_tYDQY=8LfdE6rdxuw@mail.gmail.com>
Date: Fri, 4 Dec 2020 12:59:04 +0100
Message-ID: <CAJmy8YFkkFdtTuvyZ_Qd+gCgM9zpHh=EobM+7p1dQeEui=uVZA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Restrict $GLOBALS usage
From: divinity76@gmail.com (Hans Henrik Bergan)

if this gets rid of a significant amount of implementation complexity
or runtime overhead, i'm all for it, and don't think i've ever seen
code like $GLOBALS = []; before,

given that it's technically a BC break, would have been nice as a
8.0.0 thing, but i hope it's small enough for an 8.x instead of
waiting for php9

On Fri, 4 Dec 2020 at 12:04, Nicolas Grekas
<nicolas.grekas+php@gmail.com> wrote:
>
> Hello Nikita,
>
>
> > I would like to propose the following RFC, which restricts certain rare
> > usages of $GLOBALS. This change will improve performance, reduce internal
> > implementation complexity, and fix a very large class of bugs relating to
> > $GLOBALS handling in internal functions.
> >
> > https://wiki.php.net/rfc/restrict_globals_usage
>
>
> Yes please! This will allow removing some black magic from Symfony's
> VarDumper component, which detects these "copies" of $GLOBALS:
> https://github.com/symfony/symfony/blob/31ee43a8c67897a2f61782060965f5c8a81f58a2/src/Symfony/Component/VarDumper/Cloner/VarCloner.php#L144-L155
>
> Nicolas