Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112409
To: Claude Pache <claude.pache@gmail.com>,
 PHP Internals <internals@lists.php.net>
References: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com>
Message-ID: <a66506d2-af5e-0ac8-0659-325a08d3bbcf@gmx.de>
Date: Fri, 4 Dec 2020 12:52:11 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.1
MIME-Version: 1.0
In-Reply-To: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: Missing warning for stats(), etc. when invoked with empty string
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 03.12.2020 at 11:20, Claude Pache wrote:

> `stats()` and friends invoked with empty string or null as argument, ret=
urn `false` (indicating failure), but do not emit the Warning that is expe=
cted on failure. See: https://3v4l.org/jXC2N <https://3v4l.org/jXC2N>
>
> That discrepancy between the two ways of indicating failure is problemat=
ic. Indeed, whenever I use one of those functions without prefixing it by =
@, I expect that it will either return a value of expected type (`array` i=
n case of `stats()`), or run the panic procedure of my error handler.
>
> I propose to ensure that those functions always emit a Warning in each a=
nd every situation they return false/null (provided, of course, that those=
 functions are not supposed to return `false/null` in absence of failure, =
and that their purpose is not to check failure condition as in `file_exist=
s()`).

Returning false without raising a warning has been introduced[1] to fix
bug #21410[2].  The problem back then was that without that early
return, on Windows the empty string gave erroneous stat() results, and
filetype("") returned "dir".  This is no longer the case at least as of
PHP 7.3.0 (I didn't test older versions); instead after reverting
560e33968d I now get:

Warning: stat(): stat failed for  in %s on line %d
bool(false)

So, yes, I think we should revert that commit.

[1] <https://github.com/php/php-src/commit/560e33968d>
[2] <https://bugs.php.net/21410>

Regards,
Christoph