Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112408
MIME-Version: 1.0
References: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com>
 <7E98C687-7A24-49E7-A14C-3D68B4B3419E@gmail.com> <CAAKU0ukpCZvQfgxXJjupOifHcAtkq5Kq_8Sd7JF2so6xykD03A@mail.gmail.com>
 <833C0509-8378-4881-98F0-5CD0AC9A649C@gmail.com>
In-Reply-To: <833C0509-8378-4881-98F0-5CD0AC9A649C@gmail.com>
Date: Fri, 4 Dec 2020 12:25:37 +0100
Message-ID: <CAF+90c9Cyd=euyEkAbFjy_2WEwOUy7aAuBLYyYA6yWYDCGEnBw@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: Levi Morrison <levi.morrison@datadoghq.com>, PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000429fa005b5a1bdb0"
Subject: Re: [PHP-DEV] Missing warning for stat(), etc. when invoked with
 empty string
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000429fa005b5a1bdb0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 4, 2020 at 9:33 AM Claude Pache <claude.pache@gmail.com> wrote:

>
>
> > Le 3 d=C3=A9c. 2020 =C3=A0 22:05, Levi Morrison <levi.morrison@datadogh=
q.com> a
> =C3=A9crit :
> >
> > This is a long-standing behavior. Further, I don't know many people
> > who want _more_ warnings in their codebase.
>
>
> My guess is that this position was already discussed in the occasion of
> the several past RFC whose main purpose was to introduce more
> warnings/errors/exceptions? [1], [2], [3], etc. Apparently, many people d=
o
> want more warnings...
>

This is getting a bit off-topic, but I think it's necessary to clarify:
What many of us actually want is *less* warnings. Having less warnings can
take the form of converting them to exceptions, or take the form of
removing them entirely. Both of these things happen, but the conversions to
exceptions tend to be the more controversial and thus take the spotlight.

I'm personally not a fan of warnings thrown by stream/FS functions
(especially when backed by socket streams), as robust code just ends up
having to suppress them all. Unfortunately I can't say that these warnings
are entirely useless, as they *are* helpful for debugging. It would be nice
if PHP had a stronger separation between "this is an error" warnings and
"this is informational" warnings. Things are slowly moving in this
direction with the first category being partially converted into
exceptions...

But well, that's a global problem. The current stance of stream/FS
functions is very much that all error conditions should warn.

Regards,
Nikita

--000000000000429fa005b5a1bdb0--