Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112405 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 29732 invoked from network); 4 Dec 2020 09:33:49 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 4 Dec 2020 09:33:49 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 6309A1804C6 for ; Fri, 4 Dec 2020 01:01:57 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Fri, 4 Dec 2020 01:01:56 -0800 (PST) Received: by mail-wr1-f50.google.com with SMTP id 23so4541266wrc.8 for ; Fri, 04 Dec 2020 01:01:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=aB/2fzH4sDzzsjbOghznmgBbLRWRiJ//kb2as7DEJEc=; b=AwS1aqW1/pK78rPQnWgtd2EIlJVtahSwKy9VftOMYLrVqBQfMyO7G2tnQ/owTt9rsy liygJZuiEHflvIw5mRd5LUtWOCwTJub5E+oD9tHT7833bnerIwQ0uo2xg4IQ1UnbQtW1 Fp7VxRtPO8mQhb9OCnHTIj/7IEXjK5X8kuoXL+xnE1xM1xMLJbQkEucH1w6UN5s8WUmX N2hLiO3PvDxt2p/CuMc/fuSo+wGwWpzkKjCOLQ7d2aMXILF3SguecNPSSMv1vmHxwCNo 30ykfgxx1/297yXZk5rAkX9GEmcPvTRDxjJQW+qPH5p7jja6Ufz7pqOq+lDp9NXne90H SNEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=aB/2fzH4sDzzsjbOghznmgBbLRWRiJ//kb2as7DEJEc=; b=tj7UTqtgZWwHP2pSouLMNr7bwJIUExM1RdLHe4cHcGFsBnXbRM8z2IVZszPNNM9XsR dg/M9s2JBKfexd1N6kzUA4TKFDsRINo9Iu/cSDPakIYu9c9On0+iKZ1rILzBw955c2zH eH1yO8JNP6tGY/lslV/u/yI+uK3NVsN0wn1PCivK0YH7x2yzF6jF1gCojn5XprAxz314 Unn4zHsJhmc+2006qp8BHTHz/9OgJOSB+KNJ5jnwyHqO99siDaht3EBHpq68E9ftlmA1 UbC5AmFYEU7Te+bwsB91J0r8J/LWm9oyYAAIQS1UWIQfSTA0vQ9nsdzW3U8I9JeTLM+z zdeg== X-Gm-Message-State: AOAM530Owd/yBBi3+W6qBhCMmhVfZdoCXOIVSwuw7s/UFHuL/lPcnj8U L2xO02JIAjTs6lvIhkHiWshOTMjhZD4= X-Google-Smtp-Source: ABdhPJzLsHHBof4XZOqp6byfM7Jd/LzTaozrrLn1n1QWEELrVInNJ8QWqOlIxNQ6s4fDpQep2dU62w== X-Received: by 2002:a5d:4349:: with SMTP id u9mr3565535wrr.319.1607072515484; Fri, 04 Dec 2020 01:01:55 -0800 (PST) Received: from [192.168.0.22] (cpc104104-brig22-2-0-cust548.3-3.cable.virginm.net. [82.10.58.37]) by smtp.googlemail.com with ESMTPSA id y7sm2681668wrp.3.2020.12.04.01.01.54 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Dec 2020 01:01:54 -0800 (PST) To: internals@lists.php.net References: <0774c293-afd7-d8b9-175f-217ed600d1ea@aimeos.com> <8a33dde2-f06c-640d-42bb-3e7af90fd5af@gmail.com> <75b5b870-112a-f54e-1fd7-4d425ffa8000@telia.com> <1d612903-386e-630d-f91b-fbe7590e41e6@gmx.de> <10208740-ec3b-7614-9668-b7b580ecb4cf@gmail.com> <5c68ae43-6d1e-353d-cea0-17c19cd164de@gmail.com> Message-ID: <47428592-b913-709e-548e-1629a3035bef@gmail.com> Date: Fri, 4 Dec 2020 09:01:52 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: <5c68ae43-6d1e-353d-cea0-17c19cd164de@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling From: rowan.collins@gmail.com (Rowan Tommins) On 04/12/2020 00:57, Stanislav Malyshev wrote: > > You may assert anything, but it's a fact that PHP functions have > returned nulls on bad values since forever. I'm not disputing that. I'm disputing that anyone looking at the name or documentation of this particular function would guess that "foo\0bar" is a "bad value". Clearly, somebody thought so and accounted for it as such in the implementation, but it would never have occurred to me if I hadn't read this thread. Regards, -- Rowan Tommins (né Collins) [IMSoP]