Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112404
Message-ID: <833C0509-8378-4881-98F0-5CD0AC9A649C@gmail.com>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_DBF93482-6F58-4D52-8050-105368A4D3DF"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Fri, 4 Dec 2020 09:32:35 +0100
In-Reply-To: <CAAKU0ukpCZvQfgxXJjupOifHcAtkq5Kq_8Sd7JF2so6xykD03A@mail.gmail.com>
Cc: PHP Internals <internals@lists.php.net>
To: Levi Morrison <levi.morrison@datadoghq.com>
References: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com>
 <7E98C687-7A24-49E7-A14C-3D68B4B3419E@gmail.com>
 <CAAKU0ukpCZvQfgxXJjupOifHcAtkq5Kq_8Sd7JF2so6xykD03A@mail.gmail.com>
Subject: Re: [PHP-DEV] Missing warning for stat(), etc. when invoked with
 empty string
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_DBF93482-6F58-4D52-8050-105368A4D3DF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8



> Le 3 d=C3=A9c. 2020 =C3=A0 22:05, Levi Morrison =
<levi.morrison@datadoghq.com> a =C3=A9crit :
>=20
> This is a long-standing behavior. Further, I don't know many people
> who want _more_ warnings in their codebase.


My guess is that this position was already discussed in the occasion of =
the several past RFC whose main purpose was to introduce more =
warnings/errors/exceptions? [1], [2], [3], etc. Apparently, many people =
do want more warnings...

But my main point is not exactly that. It is inconsistency in behaviour, =
that leads to wrong assumptions, that leads to incorrect code. As =
another example, see the faulty `@is_file( $data ) =3D=3D=3D false` =
check mentioned in the other thread [4].

Precisely (and I realise that maybe I wasn=E2=80=99t explicit enough in =
my message), the issue is that `stat("non/existent/file")` raises a =
warning and returns false, that leads to the wrong assumption that =
`stat($random_string)` raises a warning whenever it returns `false` =
instead of an array, that leads to the deceptive confidence that the =
`false` case will be always handled by the error handler.

=E2=80=94Claude

[1]: https://wiki.php.net/rfc/counting_non_countables =
<https://wiki.php.net/rfc/counting_non_countables>
[2]: https://wiki.php.net/rfc/notice-for-non-valid-array-container =
<https://wiki.php.net/rfc/notice-for-non-valid-array-container>
[3]: https://wiki.php.net/rfc/magic-methods-signature =
<https://wiki.php.net/rfc/magic-methods-signature>

[4]: https://externals.io/message/112333#112350 =
<https://externals.io/message/112333#112350>=

--Apple-Mail=_DBF93482-6F58-4D52-8050-105368A4D3DF--