Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112400
MIME-Version: 1.0
References: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com> <7E98C687-7A24-49E7-A14C-3D68B4B3419E@gmail.com>
In-Reply-To: <7E98C687-7A24-49E7-A14C-3D68B4B3419E@gmail.com>
Reply-To: Levi Morrison <levi.morrison@datadoghq.com>
Date: Thu, 3 Dec 2020 14:05:50 -0700
Message-ID: <CAAKU0ukpCZvQfgxXJjupOifHcAtkq5Kq_8Sd7JF2so6xykD03A@mail.gmail.com>
To: Claude Pache <claude.pache@gmail.com>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Missing warning for stat(), etc. when invoked with
 empty string
From: internals@lists.php.net ("Levi Morrison via internals")

On Thu, Dec 3, 2020 at 6:30 AM Claude Pache <claude.pache@gmail.com> wrote:
>
> [Of course, I meant `stat()`, not `stats()`. Resending the message with c=
orrect spelling, including in subject line. Sorry.]
>
>
> Hi,
>
> `stat()` and friends invoked with empty string or null as argument, retur=
n `false` (indicating failure), but do not emit the Warning that is expecte=
d on failure. See: https://3v4l.org/jXC2N <https://3v4l.org/jXC2N>
>
> That discrepancy between the two ways of indicating failure is problemati=
c. Indeed, whenever I use one of those functions without prefixing it by @,=
 I expect that it will either return a value of expected type (`array` in c=
ase of `stat()`), or run the panic procedure of my error handler.
>
> I propose to ensure that those functions always emit a Warning in each an=
d every situation they return false/null (provided, of course, that those f=
unctions are not supposed to return `false/null` in absence of failure, and=
 that their purpose is not to check for failure condition as in `file_exist=
s()`).
>
> =E2=80=94Claude
>

This is a long-standing behavior. Further, I don't know many people
who want _more_ warnings in their codebase.

In other words, I disagree with this proposal.