Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112396
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_DA812E17-EA67-43B3-ABA6-4B17C73D24D7"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Message-ID: <34FA3E20-9D06-4D08-937E-4216FEF35504@gmail.com>
Date: Thu, 3 Dec 2020 11:20:07 +0100
To: PHP Internals <internals@lists.php.net>
Subject: Missing warning for stats(), etc. when invoked with empty string
From: claude.pache@gmail.com (Claude Pache)

--Apple-Mail=_DA812E17-EA67-43B3-ABA6-4B17C73D24D7
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8


Hi,

`stats()` and friends invoked with empty string or null as argument, =
return `false` (indicating failure), but do not emit the Warning that is =
expected on failure. See: https://3v4l.org/jXC2N =
<https://3v4l.org/jXC2N>

That discrepancy between the two ways of indicating failure is =
problematic. Indeed, whenever I use one of those functions without =
prefixing it by @, I expect that it will either return a value of =
expected type (`array` in case of `stats()`), or run the panic procedure =
of my error handler.

I propose to ensure that those functions always emit a Warning in each =
and every situation they return false/null (provided, of course, that =
those functions are not supposed to return `false/null` in absence of =
failure, and that their purpose is not to check failure condition as in =
`file_exists()`).

=E2=80=94Claude=

--Apple-Mail=_DA812E17-EA67-43B3-ABA6-4B17C73D24D7--