Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112390
Return-Path: <come.chilliet@fusiondirectory.org>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 6189 invoked from network); 3 Dec 2020 08:59:49 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 3 Dec 2020 08:59:49 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id B031A180531
	for <internals@lists.php.net>; Thu,  3 Dec 2020 00:27:41 -0800 (PST)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
	SPF_PASS autolearn=no autolearn_force=no version=3.4.2
X-Spam-Virus: No
X-Envelope-From: <come.chilliet@fusiondirectory.org>
Received: from smtp-in.fusiondirectory.org (smtp-in.fusiondirectory.org [195.154.20.156])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Thu,  3 Dec 2020 00:27:40 -0800 (PST)
Received: from smtp-in.fusiondirectory.org (localhost.localdomain [127.0.0.1])
	by smtp-in.fusiondirectory.org (Proxmox) with ESMTP id BB8EB1016CA
	for <internals@lists.php.net>; Thu,  3 Dec 2020 09:27:38 +0100 (CET)
Received: from smtp.fusiondirectory.org (smtp.fusiondirectory.org [195.154.20.141])
	by smtp-in.fusiondirectory.org (Proxmox) with ESMTP id 8ACD7101658
	for <internals@lists.php.net>; Thu,  3 Dec 2020 09:27:38 +0100 (CET)
Received: from mcmic-probook.opensides.be (63.120.199.77.rev.sfr.net [77.199.120.63])
	by smtp.fusiondirectory.org (Postfix) with ESMTPSA id 5B43425EADF
	for <internals@lists.php.net>; Thu,  3 Dec 2020 09:27:38 +0100 (CET)
Date: Thu, 3 Dec 2020 09:27:36 +0100
To: PHP Internals <internals@lists.php.net>
Message-ID: <20201203092736.6216e9cc@mcmic-probook.opensides.be>
In-Reply-To: <d798030e-e383-2ae5-f84c-d1175858970d@gmail.com>
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
	<b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de>
	<0774c293-afd7-d8b9-175f-217ed600d1ea@aimeos.com>
	<fad4cc49-0f40-53f1-400c-90ff01ffdccb@gmx.de>
	<CAN2symiHHJVGvaLYMD=Qes0Wy06dZRtzPeonNBUWOBRbiTdo5g@mail.gmail.com>
	<CAFPFaMLEdq0+hYkE49YVbcFvCt00rne6roApcoyY4aK=1ZHpuA@mail.gmail.com>
	<29529061-dc71-c759-590a-b4786936f8c5@aimeos.com>
	<96e40442-a649-f9af-a0cc-dd43cfd1bd0c@gmx.de>
	<CAF+90c-xkV0PUBmOysrQYKoH2-muw0RHSamNJmM27HX1n+Px1Q@mail.gmail.com>
	<d798030e-e383-2ae5-f84c-d1175858970d@gmail.com>
Organization: FusionDirectory
X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling
From: come.chilliet@fusiondirectory.org (=?UTF-8?B?Q8O0bWU=?= Chilliet)

Le Tue, 1 Dec 2020 12:06:22 -0800,
Stanislav Malyshev <smalyshev@gmail.com> a =C3=A9crit :

> But it's not incorrect. if is_file("abc\0") returns false, it's correct=20
> - "abc\0" is not a correct filename, so I expect it to return false. It=20
> does exactly what I need, so it's correct.

Hear hear. I think this is the best summary in this discussion.

is_file and is_dir should just return false on values which are not files a=
nd
dirs.

Can we please fix this for future PHP versions?
Does it need an RFC?