Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112387
To: Rowan Tommins <rowan.collins@gmail.com>, internals@lists.php.net
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
 <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de>
 <0774c293-afd7-d8b9-175f-217ed600d1ea@aimeos.com>
 <fad4cc49-0f40-53f1-400c-90ff01ffdccb@gmx.de>
 <CAN2symiHHJVGvaLYMD=Qes0Wy06dZRtzPeonNBUWOBRbiTdo5g@mail.gmail.com>
 <CAFPFaMLEdq0+hYkE49YVbcFvCt00rne6roApcoyY4aK=1ZHpuA@mail.gmail.com>
 <8a33dde2-f06c-640d-42bb-3e7af90fd5af@gmail.com>
 <75b5b870-112a-f54e-1fd7-4d425ffa8000@telia.com>
 <A059723E-4320-45B1-B20C-CCC53DF60FD3@gmail.com>
Message-ID: <1d612903-386e-630d-f91b-fbe7590e41e6@gmx.de>
Date: Thu, 3 Dec 2020 00:49:26 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <A059723E-4320-45B1-B20C-CCC53DF60FD3@gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 03.12.2020 at 00:06, Rowan Tommins wrote:

> On 2 December 2020 22:38:13 GMT+00:00, "Bj=C3=B6rn Larsson" <bjorn.x.lar=
sson@telia.com> wrote:
>
>> One could add that here the PHP programmer need to do work that
>> basically
>> replicate how the code worked earlier for little gain.
>
> Just to reiterate, the previous implementation was also bad - it returne=
d an entirely undocumented and unexpected null value.

Just to reiterate, the former behavior was documented[1], and the return
value was *undefined*.  Instead of returning NULL, the erroneous
function call could have returned anything, even TRUE.  Relying on
undefined behavior is bad.

That said, I'm not against changing the behavior of is_file() and
is_dir() as requested, and also the behavior of is_readable(),
is_writable() and file_exists().  There are likely more
functions/methods whose behavior should be changed accordingly.  It
might be worthwhile to identify these functions.

And we should also explicitly document what these functions returned for
paths containing NUL bytes prior to PHP 8.0.0.

[1] <https://www.php.net/manual/en/functions.internal.php>

Regards,
Christoph