Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112386
Date: Wed, 02 Dec 2020 23:06:59 +0000
User-Agent: K-9 Mail for Android
In-Reply-To: <75b5b870-112a-f54e-1fd7-4d425ffa8000@telia.com>
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com> <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de> <0774c293-afd7-d8b9-175f-217ed600d1ea@aimeos.com> <fad4cc49-0f40-53f1-400c-90ff01ffdccb@gmx.de> <CAN2symiHHJVGvaLYMD=Qes0Wy06dZRtzPeonNBUWOBRbiTdo5g@mail.gmail.com> <CAFPFaMLEdq0+hYkE49YVbcFvCt00rne6roApcoyY4aK=1ZHpuA@mail.gmail.com> <8a33dde2-f06c-640d-42bb-3e7af90fd5af@gmail.com> <75b5b870-112a-f54e-1fd7-4d425ffa8000@telia.com>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: internals@lists.php.net
Message-ID: <A059723E-4320-45B1-B20C-CCC53DF60FD3@gmail.com>
Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling
From: rowan.collins@gmail.com (Rowan Tommins)

On 2 December 2020 22:38:13 GMT+00:00, "Bj=C3=B6rn Larsson" <bjorn=2Ex=2Ela=
rsson@telia=2Ecom> wrote:
>One could add that here the PHP programmer need to do work that
>basically
>replicate how the code worked earlier for little gain=2E


Just to reiterate, the previous implementation was also bad - it returned =
an entirely undocumented and unexpected null value=2E

In many cases, that will have worked because it was implicitly cast to boo=
lean, but in some cases it will already have led to a TypeError being throw=
n, e=2Eg=2E in a wrapper like this:

<?php declare(strict_types=3D1);
class Dir {
    private $path;
    // =2E=2E=2E
    public function hasFile(string $name): bool {
         return is_file("$path/$name");
    }
}


Regards,

--=20
Rowan Tommins
[IMSoP]