Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112357 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 17951 invoked from network); 1 Dec 2020 20:42:25 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 1 Dec 2020 20:42:25 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 067221804C4 for ; Tue, 1 Dec 2020 12:09:55 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 1 Dec 2020 12:09:54 -0800 (PST) Received: by mail-pg1-f182.google.com with SMTP id m9so1863690pgb.4 for ; Tue, 01 Dec 2020 12:09:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=C/O+R4WKgCabodfXKZMMWpQkakSFCUMGTY28pxIsWYg=; b=knJHOJe7SFZr+uR6h9qPUgjifPS3OlouFsMBzGHARrxA2KRX93HO4UUp+ZctYbJhAe SX8TmUdRTOxn2WKfJ8vCZxyVNtmu/xR8D1clZTRHoGA72fLKkUsVjpWkhslTM5zSU6bd A+ZBk9jlNYXhocGcs2jro8ohEzw/jaQ38ixJK9Soc/YXIgfDo2Tc+i8fe2sSuGnf6jlZ hSqfqhv3DuXnl3q7xFvXqn7173/ezT65YOENu+iwWQeTIS3vrCHn7N+by5drIQY+5oLp tZ5E5jgTxwbm/bT01z+MzcGN1KBu3nb9vBRPOIewnaKr9FU6qfvm1JaXTET6xuBlL6IR kAnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=C/O+R4WKgCabodfXKZMMWpQkakSFCUMGTY28pxIsWYg=; b=YUe0DOvtxeEcXwWlx3vqVKiZN0UW0yRqvxKVlp58cPrFStb0zNYJENrxyt8n8xyPYA /bG9IitrayfZcJoKDuEdPribvD3YZ2ZgfiBSBmDO9UrP3skGTumE/gCiF7+/WAgI5/Ag jOSR6tIenf26iJzRnPT+M0gUYr/Dth83y3Vzu26OaM6nD//sq2B0l6FD7KckCtKidSB8 30+ZEaF+bVyUKm6SidWgZyBEMVXVHqMjH2ZvGOKIRQypAZk5wq51IOaPWiZkerYJkmiA kLv6iwYRF50dTxQS9BalrX6gFJQf0Wza+LhO8643qfWyOhieEo/XSdtR6LcvdTUgOLGg nl2Q== X-Gm-Message-State: AOAM530QWiQ8fiCPj1XQIIioI9jzDMrUfBxAQWW3Jsrb0XpUZ5IXCVEy zv2KSVWYA8g+emyBs/GfsZUyWLPkypjv X-Google-Smtp-Source: ABdhPJzOalx7fKEQLGy8uq40qs1Iw0Ut4ERU19D9D6s9SfaNO5DcfcrW8xRRjSsJx5mK/we5F1907Q== X-Received: by 2002:aa7:8744:0:b029:18b:a9e1:803d with SMTP id g4-20020aa787440000b029018ba9e1803dmr4077186pfo.50.1606853392261; Tue, 01 Dec 2020 12:09:52 -0800 (PST) Received: from Stas-Mac-3.local (ec2-44-226-106-152.us-west-2.compute.amazonaws.com. [44.226.106.152]) by smtp.gmail.com with ESMTPSA id w196sm539960pfc.218.2020.12.01.12.09.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Dec 2020 12:09:51 -0800 (PST) To: internals@lists.php.net References: <3dd3c22d-0959-5425-46b1-dade4ac75b00@rhsoft.net> Message-ID: Date: Tue, 1 Dec 2020 12:09:51 -0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <3dd3c22d-0959-5425-46b1-dade4ac75b00@rhsoft.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling From: smalyshev@gmail.com (Stanislav Malyshev) Hi! > we are running error_reporting E_ALL for 17 years now and don't > distinct between notice / warning / error, it has to be fixed - > period Surely you do. Your code continues to run after warning/notice but stops after the error. It's impossible to ignore that. Unless you have an error handler that does exit() after a notice (which I have hard time believing, honestly, but who knows), there is a very major distinction. It's not about what "has to be fixed" - it's not about the contents of your bug tracking database - it's about the code that run one way and suddenly now runs (or, rather, fails) in a fundamentally different way. -- Stas Malyshev smalyshev@gmail.com