Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112340
MIME-Version: 1.0
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
 <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de> <CAN2symjht9iZLDhYEKCYb9V7B4xEoHBG8MFMoAVQS55OKzWC7Q@mail.gmail.com>
 <CAFPFaM+Np_jQgDFr8vV8TofYyLMZ0EDWmt3+yr1_KQzJTbW6MQ@mail.gmail.com> <CAFPFaMLULyFB0R14rQGCPmzZdXUSg81rHJQEQPRK2C6tDK6__w@mail.gmail.com>
In-Reply-To: <CAFPFaMLULyFB0R14rQGCPmzZdXUSg81rHJQEQPRK2C6tDK6__w@mail.gmail.com>
Date: Tue, 1 Dec 2020 09:54:11 -0800
Message-ID: <CAN2symg4xiw90H7Jd+HUDgjK+F+kDV_UW_9uf8LeMnyBAca09Q@mail.gmail.com>
To: "G. P. B." <george.banyard@gmail.com>
Cc: "Christoph M. Becker" <cmbecker69@gmx.de>, "Aimeos | Norbert Sendetzky" <norbert@aimeos.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling
From: paul.crovella@gmail.com (Paul Crovella)

On Tue, Dec 1, 2020 at 9:48 AM G. P. B. <george.banyard@gmail.com> wrote:
>
>
> On Tue, 1 Dec 2020 at 17:46, G. P. B. <george.banyard@gmail.com> wrote:
>>
>> On Tue, 1 Dec 2020 at 17:45, Paul Crovella <paul.crovella@gmail.com> wrote:
>>>
>>> On Tue, Dec 1, 2020 at 9:25 AM Christoph M. Becker <cmbecker69@gmx.de> wrote:
>>> >
>>> > On 01.12.2020 at 18:18, Aimeos | Norbert Sendetzky wrote:
>>> >
>>> > > PHP 8 is stricter in checking input data then PHP 7. This is good but
>>> > > has some side effects for is_file(), is_dir() and similar functions when
>>> > > invalid paths are passed for checking.
>>> > >
>>> > > In PHP 7, this returns FALSE:
>>> > >
>>> > > php -r 'var_dump(is_file("ab\0c"));'
>>> > >
>>> > > In PHP 8, the same code throws a ValueException. Problem is now that
>>> > > it's not possible to check upfront if the passed argument is a valid
>>> > > path to avoid the exception being thrown.
>>> >
>>> > This is only about the NUL byte in the filename.  You can easily check
>>> > for that yourself. :)
>>> >
>>> > Regards,
>>> > Christoph
>>>
>>> Or is_file could check for it, handle it gracefully, and be a safe
>>> function to call without worrying about this undocumented edge case.
>>>
>>> --
>>> PHP Internals - PHP Runtime Development Mailing List
>>> To unsubscribe, visit: https://www.php.net/unsub.php
>>>
>>
>
> Apologize my email client sent by mistake:
> But this has always generated a warning see:
> https://3v4l.org/7E2mv
>
> So this is not new behaviour.
>
> George P. Banyard

The result is in fact new. An uncaught ValueError isn't a warning.