Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112337
MIME-Version: 1.0
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com> <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de>
In-Reply-To: <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de>
Date: Tue, 1 Dec 2020 09:45:16 -0800
Message-ID: <CAN2symjht9iZLDhYEKCYb9V7B4xEoHBG8MFMoAVQS55OKzWC7Q@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: "Aimeos | Norbert Sendetzky" <norbert@aimeos.com>, PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: PHP 8 is_file/is_dir input handling
From: paul.crovella@gmail.com (Paul Crovella)

On Tue, Dec 1, 2020 at 9:25 AM Christoph M. Becker <cmbecker69@gmx.de> wrote:
>
> On 01.12.2020 at 18:18, Aimeos | Norbert Sendetzky wrote:
>
> > PHP 8 is stricter in checking input data then PHP 7. This is good but
> > has some side effects for is_file(), is_dir() and similar functions when
> > invalid paths are passed for checking.
> >
> > In PHP 7, this returns FALSE:
> >
> > php -r 'var_dump(is_file("ab\0c"));'
> >
> > In PHP 8, the same code throws a ValueException. Problem is now that
> > it's not possible to check upfront if the passed argument is a valid
> > path to avoid the exception being thrown.
>
> This is only about the NUL byte in the filename.  You can easily check
> for that yourself. :)
>
> Regards,
> Christoph

Or is_file could check for it, handle it gracefully, and be a safe
function to call without worrying about this undocumented edge case.