Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112334
To: Aimeos | Norbert Sendetzky <norbert@aimeos.com>,
 PHP internals <internals@lists.php.net>
References: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
Message-ID: <b546b5bf-27f8-62cc-cc4b-d859132998a4@gmx.de>
Date: Tue, 1 Dec 2020 18:24:35 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.5.0
MIME-Version: 1.0
In-Reply-To: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
Content-Type: text/plain; charset=utf-8
Content-Language: de-DE
Content-Transfer-Encoding: quoted-printable
Subject: Re: PHP 8 is_file/is_dir input handling
From: cmbecker69@gmx.de ("Christoph M. Becker")

On 01.12.2020 at 18:18, Aimeos | Norbert Sendetzky wrote:

> PHP 8 is stricter in checking input data then PHP 7. This is good but
> has some side effects for is_file(), is_dir() and similar functions when
> invalid paths are passed for checking.
>
> In PHP 7, this returns FALSE:
>
> php -r 'var_dump(is_file("ab\0c"));'
>
> In PHP 8, the same code throws a ValueException. Problem is now that
> it's not possible to check upfront if the passed argument is a valid
> path to avoid the exception being thrown.

This is only about the NUL byte in the filename.  You can easily check
for that yourself. :)

Regards,
Christoph