Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112333
To: PHP internals <internals@lists.php.net>
Organization: Aimeos GmbH
Message-ID: <b845d5bf-63da-d564-1f0f-cc934188d693@aimeos.com>
Date: Tue, 1 Dec 2020 18:18:17 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: PHP 8 is_file/is_dir input handling
From: norbert@aimeos.com (Aimeos | Norbert Sendetzky)

Hi internals

PHP 8 is stricter in checking input data then PHP 7. This is good but
has some side effects for is_file(), is_dir() and similar functions when
invalid paths are passed for checking.

In PHP 7, this returns FALSE:

php -r 'var_dump(is_file("ab\0c"));'

In PHP 8, the same code throws a ValueException. Problem is now that
it's not possible to check upfront if the passed argument is a valid
path to avoid the exception being thrown.

My suggestion for simpler client side code would be to return FALSE in
this situation for PHP 8 too instead of throwing the ValueException.
Otherwise, it's not possible to use is_file() and related functions
without adding a try/catch block around in any web application.

Best,


Norbert