Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112331
MIME-Version: 1.0
References: <0d07a6b09358fd2047eec9874214a297097f398762c1ca784b62ecef2eca35bc@mahalux.com>
In-Reply-To: <0d07a6b09358fd2047eec9874214a297097f398762c1ca784b62ecef2eca35bc@mahalux.com>
Date: Tue, 1 Dec 2020 16:46:57 +0100
Message-ID: <CAF+90c_icKbnH4a-zJry7Oats-fB0zqVZ_8OgeDsAOYfwObQKw@mail.gmail.com>
To: =?UTF-8?B?TWljaGFlbCBWb8WZw63FoWVrIC0gxIxWVVQgRkVM?= <vorismi3@fel.cvut.cz>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000005ae37a05b5690a24"
Subject: Re: [PHP-DEV] DateTimeInterface interface stub has no modify method
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000005ae37a05b5690a24
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Dec 1, 2020 at 4:35 PM Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVUT F=
EL <
vorismi3@fel.cvut.cz> wrote:

> Intentionally?
>
> It is an issue for static analysers...
>
> With kind regards / Mit freundlichen Gr=C3=BC=C3=9Fen / S p=C5=99=C3=A1te=
lsk=C3=BDm pozdravem,
>
> Michael Vo=C5=99=C3=AD=C5=A1ek
> =C4=8CVUT FEL


Yes, this is intentional. The DateTimeInterface interface (has absolutely
nothing to do with stubs -- this is the same in PHP 7) only includes the
methods that are present in both DateTime and DateTimeImmuatable **with the
same behavior**.

DateTime::modify() and DateTimeImmutable::modify(), while having the same
signature, do completely different things. One performs an in-place
modification, while the other doesn't.

You should be doing one of two things:

1. Only accept DateTimeImmutable.
2. Accept DateTimeInterface and then use
DateTimeImmutable::createFromInterface() to convert it into a
DateTimeImmutable.

Working on a plain DateTimeInterface only makes sense if you are using the
read-only methods, which are the ones that are part of the
DateTimeInterface interface.

Regards,
Nikita

--0000000000005ae37a05b5690a24--