Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112295
MIME-Version: 1.0
References: <CAESVnVondESo8s6GDjXwFD6TCiWyHzp1MVg-9R6fwzPNi1TeMw@mail.gmail.com>
 <0a4be3c3-d199-ae32-3d9c-9a2c4d2443f9@php.net>
In-Reply-To: <0a4be3c3-d199-ae32-3d9c-9a2c4d2443f9@php.net>
Date: Thu, 26 Nov 2020 16:30:43 +0300
Message-ID: <CAPVMwwviiwJZcizv0REShGR+HW=yR-nUYQ+zO5=ShbHh16ewpw@mail.gmail.com>
To: Remi Collet <remi@php.net>
Cc: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000a10d1305b5028dac"
Subject: Re: [PHP-DEV] ZEND_ENGINE_4
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000a10d1305b5028dac
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

We don't need ZEND_ENGINE_4 for PHP 8.*.
PHP 8.0 didn't introduce revolutionary engine changes (like PHP 7 and PHP 5
did), and we won't introduce big engine changes in minor releases.

Thanks. Dmitry.

On Thu, Nov 26, 2020 at 11:44 AM Remi Collet <remi@php.net> wrote:

> Le 26/11/2020 =C3=A0 03:41, Sara Golemon a =C3=A9crit :
> > Maybe just a wee bit late to ask this question, but shouldn't we have
> long
> > since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?
>
>  From a quick search I see some usage of ZEND_ENGINE_3
> (eg, imagick and gmagick ext, probably others)
>
> > Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
> > surface area hasn't skewed so bad?
>
> Indeed,
>
> This is mostly used to test for PHP 5 vs 7/8 API
>
> >
> > I ask because ZEND_VERSION did get updated to the 4.x.x series.
>
> IMHO, we should keep ZEND_ENGINE_3 to not break things so late
> and encourage dev to not use it anymore
>
> And drop it in 8.1 (without ZEND_ENGINE_4)
>
> Remi
>
> >
> > -Sara
> >
>
>
> P.S. https://github.com/Imagick/imagick/pull/363
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000a10d1305b5028dac--