Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112293
To: internals@lists.php.net
References: <CAESVnVondESo8s6GDjXwFD6TCiWyHzp1MVg-9R6fwzPNi1TeMw@mail.gmail.com>
Message-ID: <0a4be3c3-d199-ae32-3d9c-9a2c4d2443f9@php.net>
Date: Thu, 26 Nov 2020 09:44:40 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <CAESVnVondESo8s6GDjXwFD6TCiWyHzp1MVg-9R6fwzPNi1TeMw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [PHP-DEV] ZEND_ENGINE_4
From: remi@php.net (Remi Collet)

Le 26/11/2020 à 03:41, Sara Golemon a écrit :
> Maybe just a wee bit late to ask this question, but shouldn't we have long
> since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?

 From a quick search I see some usage of ZEND_ENGINE_3
(eg, imagick and gmagick ext, probably others)

> Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
> surface area hasn't skewed so bad?

Indeed,

This is mostly used to test for PHP 5 vs 7/8 API

> 
> I ask because ZEND_VERSION did get updated to the 4.x.x series.

IMHO, we should keep ZEND_ENGINE_3 to not break things so late
and encourage dev to not use it anymore

And drop it in 8.1 (without ZEND_ENGINE_4)

Remi

> 
> -Sara
> 


P.S. https://github.com/Imagick/imagick/pull/363