Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112292
MIME-Version: 1.0
References: <CAESVnVondESo8s6GDjXwFD6TCiWyHzp1MVg-9R6fwzPNi1TeMw@mail.gmail.com>
In-Reply-To: <CAESVnVondESo8s6GDjXwFD6TCiWyHzp1MVg-9R6fwzPNi1TeMw@mail.gmail.com>
Date: Thu, 26 Nov 2020 02:54:33 +0000
Message-ID: <CAFPFaMJRBSCR5=MvrNXYjo_uA2T7jMtDQr24nndgnyc61Xvvxg@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000008ea10c05b4f9aa10"
Subject: Re: [PHP-DEV] ZEND_ENGINE_4
From: george.banyard@gmail.com ("G. P. B.")

--0000000000008ea10c05b4f9aa10
Content-Type: text/plain; charset="UTF-8"

On Thu, 26 Nov 2020 at 02:42, Sara Golemon <pollita@php.net> wrote:

> Maybe just a wee bit late to ask this question, but shouldn't we have long
> since changed `#define ZEND_ENGINE_3` to `#degine ZEND_ENGINE_4` ?
>
> Was that deliberate since (unlike with 4->5 and 5->7) the engine's API
> surface area hasn't skewed so bad?
>
> I ask because ZEND_VERSION did get updated to the 4.x.x series.
>
> -Sara
>

Wasn't there discussion about dropping the ZEND_ENGINE_* constant?
As the Zend API changes between minor versions it is debatable how better
it is to check for that constant instead of a version number.

Best,

George P. Banyard

--0000000000008ea10c05b4f9aa10--