Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112280
MIME-Version: 1.0
References: <CA+kxMuRjJ5B_ykNXeMZhAd6iduh-VEk7CNP0vNuZp9fjka5_HQ@mail.gmail.com>
 <CAAKU0u=cHBO1r=vA9_KdXzrPGzQuiCksPTPYZZB5d0mSfrDxfw@mail.gmail.com>
 <CAJmy8YF2Un=Di_xOL=dnQ8nhOHO4ZbyptXz4PRLnYY=zZDzK1A@mail.gmail.com>
 <CA+kxMuTm+UorKQ=YU96c_k6H-c3CVhmA7gu12K-6Sf532Qrpag@mail.gmail.com>
 <55e200cf-ed16-e935-4e09-728ce3362cba@gmx.de> <CAEsg9X2w=Bty-4oVsN1ac6+J6PFko7XAajGfk4os7cruQS8Yxw@mail.gmail.com>
 <CAESVnVp42zB6paMoBfKAfDF8kdH3_3-8KZkvk=AzPESmH57C9Q@mail.gmail.com> <CAEsg9X3zx9sAdap3JTkua6g3jki8QcsHVixYfH_+9xwNg4wA1Q@mail.gmail.com>
In-Reply-To: <CAEsg9X3zx9sAdap3JTkua6g3jki8QcsHVixYfH_+9xwNg4wA1Q@mail.gmail.com>
Date: Tue, 24 Nov 2020 17:27:24 +0000
Message-ID: <CA+kxMuR7y_O_F72o8c-A83fLz35q_iskBT7rjrLOFySMWxkqog@mail.gmail.com>
To: David Rodrigues <david.proweb@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] [RFC] Draft - Closure self reference
From: Danack@basereality.com (Dan Ackroyd)

Sara Golemon wrote:
> looks a bit... ugly? weird? surprising?

I had the same initial reaction, and was going to tell David what I
thought of the suggestion. But after a couple of days, I was unable to
actually articulate what I didn't like it, so think I was just having
a gut reaction to something I hadn't seen before, and so wasn't used
to seeing.

Sara Golemon wrote:
> That's a lot of... stuff

Yeah, but it's a really rare use-case for a closure to need to be able
to reference itself, so I think it's probably fine to have some
verbosity around "this closure is doing something quite unusual".

I personally think any of:

function (... $args) as $lambda: returnType use ($captures...) {}
function (... $args): returnType as $lambda use ($captures...) {}
function (... $args): returnType use ($captures...) as $lambda {}

would be fine and various 'my aesthetic choice is objectively the
best' arguments, could be made for any of them.

David Rodrigues wrote:
> I ended up preferring this last option.

I prefer the others as I think they are more deliberate syntax (i.e.
don't look like a typo), avoid confusion around why can't normal
functions be declared with leading $'s, and almost certainly would be
easier to search for what they are. e.g. "php closure as variable"

cheers
Dan
Ack