Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112279
MIME-Version: 1.0
References: <CAESVnVqoLLCmEC0CcDT9GvfyU6NRiGt04hY3aBUopr9+dE=D1A@mail.gmail.com>
 <CAPVMwwtnvhBRA0o6oC4KejT_HSipvTxrFRRE+EvbzMyfczjMDg@mail.gmail.com>
 <CAESVnVoW+M3SY0tZU_Qq=EjO1Am=MNYc9ySSx=59DB1gcRXwxg@mail.gmail.com> <CAESVnVopEO=GoNqfg=i48O7UXdrn7-448wqAAPJLum5x9H8beA@mail.gmail.com>
In-Reply-To: <CAESVnVopEO=GoNqfg=i48O7UXdrn7-448wqAAPJLum5x9H8beA@mail.gmail.com>
Date: Tue, 24 Nov 2020 19:43:52 +0300
Message-ID: <CAPVMwwvNuNk8_x1Q7kyGTdPX=tEvY1+aXhmRT8z547OyMde8Fg@mail.gmail.com>
To: Sara Golemon <pollita@php.net>
Cc: Gabriel Caruso <carusogabriel@php.net>, PHP internals <internals@lists.php.net>, 
	Nikita Popov <nikita.ppv@gmail.com>
Content-Type: multipart/alternative; boundary="000000000000b630d505b4dd0469"
Subject: Re: [PHP-DEV] Preparing for PHP 8.0.0 GA
From: dmitrystogov@gmail.com (Dmitry Stogov)

--000000000000b630d505b4dd0469
Content-Type: text/plain; charset="UTF-8"

On Tue, Nov 24, 2020 at 6:14 PM Sara Golemon <pollita@php.net> wrote:

> On Tue, Nov 24, 2020 at 8:55 AM Sara Golemon <pollita@php.net> wrote:
>
>> Given that the JIT is enabled by default, I'm tempted to add another RC
>> and delay the release.
>>
>>
> As Niki just helpfully pointed out; My understanding of the JIT's setting
> on 8.0 is wrong.  It's "on", but with a 0-sized buffer, so it's effectively
> disabled.
> #1 I feel so much more secure in this whole release than I did five
> minutes ago. No offence. :)
> #2 We can afford to be a little lax on pulling in those cherry-picks.
>
> So now the question is what is the impact of (not) pulling them into the
> release at the literal last minute.
> On the one hand, by the book, this is too late for a non-security fix.  On
> the other hand, this is .0, and it's impacting a not-enabled-by-default
> path, so we can be more generous.
>
>

I think many people are going to try JIT in PHP-8.0.0. The last commits fix
incorrect behavior of JIT generated code on some edge cases. e.g. wrong
reference-counting and following use-after-free on PHPUnit tests. Releasing
PHP-8.0.0 with already fixed bugs would cause false reports. On the other
hand the risk of these commits is minimal.

Thanks. Dmitry.


> Right now I'm inclined to pull them in, but I'll wait a few hours for
> anyone who wishes to object. (It's still only 9am here :p )
>
> -Sara
>

--000000000000b630d505b4dd0469--