Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112274 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 45422 invoked from network); 24 Nov 2020 15:30:29 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 24 Nov 2020 15:30:29 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 63A8E1804B3 for ; Tue, 24 Nov 2020 06:56:10 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: * X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 24 Nov 2020 06:56:09 -0800 (PST) Received: by mail-lf1-f46.google.com with SMTP id r24so13119765lfm.8 for ; Tue, 24 Nov 2020 06:56:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Y7cUYXg+SFs5iKpQ4XtnHbmPQCPoFeU3A5zt7MwlrQA=; b=qCCIK/Y4j1Ruw/ZQpQzWnaRKusqd0JrkKKrs9MBXqQ0Fz0qoqXXSDLBDVVB+qqfYrx jLwvkZWmAOM0S9ovrvCgMS+Vz9qTsbYUdA1rEkqIhK1WMb8y3rbsFEwNxetYeAB3VD3K 4caT1aZ01U4qWFntUCo7DrYN7xsut34ZXO1EW43Y+TUKODJMvUiOq9mX5ktAp3oIniZ4 QnCSqzadcqsvPaqjIibeTnCPL4itGxsFlcaUnfWlehIyzfTp4j86Lt1LYwKuBYtrFdpN Sunzq5u3g1K4/bA6DuMOcCL4cRMkbawERLyb54UIC60NQ2/n2sJi+Ctf2B4LeUuBkSg4 fOhw== X-Gm-Message-State: AOAM532C55wBxJSZxOZdDvwB2QkP9ArkqtBCur06invPiXhNoOzvMzrB m/SZwCTij+Zv17MvbJXkTDFGoKYT0YJ8c0WwdyuRQQ== X-Google-Smtp-Source: ABdhPJwJg2qqeJq18zcW/NlcIfG+a1PLt6RI3rP++qnZqENK2avxLqUjVVoXvgSt4pF7DHrK+ixPUuh/Uzp31HJhcos= X-Received: by 2002:ac2:46f3:: with SMTP id q19mr2120814lfo.76.1606229768113; Tue, 24 Nov 2020 06:56:08 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Tue, 24 Nov 2020 08:55:57 -0600 Message-ID: To: Dmitry Stogov Cc: Gabriel Caruso , PHP internals , Nikita Popov Content-Type: multipart/alternative; boundary="000000000000c1a65905b4db82c3" Subject: Re: [PHP-DEV] Preparing for PHP 8.0.0 GA From: pollita@php.net (Sara Golemon) --000000000000c1a65905b4db82c3 Content-Type: text/plain; charset="UTF-8" On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov wrote: > I finally fixed all the known JIT related issues and made the PHP-8.0 > build "green". > > > https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13088&view=results > > Please, cherry-pick the following 5 commits into PHP-8.0.0. > > c8df28d276c25c6f5ad0f1ab2727804b32be8cfe > c0d1dbcb432f65d09f1c88cc368aa89eb5f067f4 > 4cf3da73839b1ef3ab1fc8f74aee3a00237ad6b5 > 586ccfdfd5179336dcf3719577b8258e55e7d76e > 337d2af6ca50a52864034446d863331cbc61885e > >> >> Hi Dmitry, that's great news. Given that the JIT is enabled by default, I'm tempted to add another RC and delay the release. As the person who did this work, can you reassure my worries and tell me that's not needed? The good news is that none of these commits look particularly complex. -Sara c8df28d276 Fixed 32-bit JIT c0d1dbcb43 Fixed incorrect TRACE_FRAME_MASK_NESTED flag setting 4cf3da7383 Keep value of register before possible side exit 586ccfdfd5 Fixed use-after-free in PHPUnit tests 337d2af6ca zend_jit_trace_stack_frame.stack can't be NULL --000000000000c1a65905b4db82c3--