Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112256
Message-ID: <CC1CA49A-3AB2-4356-9D0C-45C747E5EDBE@cpanel.net>
Content-Type: multipart/alternative;
	boundary="Apple-Mail=_08A971E1-E878-41D7-BC11-E55D886A02AF"
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.4\))
Date: Wed, 18 Nov 2020 16:21:30 -0600
In-Reply-To: <CAF+90c_9hczW6CeGAhPzwm+Bvyp0VCQUvRrgNjhPv5=jNYxzpw@mail.gmail.com>
Cc: Dan Ackroyd <Danack@basereality.com>,
 PHP internals <internals@lists.php.net>
To: Nikita Popov <nikita.ppv@gmail.com>
References: <AFBF0B96-BE69-4D51-A549-741D0597DAAF@cpanel.net>
 <CA+kxMuR6wwxX_V0UfjkVLbKeckP96iuw8qMiwTroMKSoGWjOGQ@mail.gmail.com>
 <CAF+90c_9hczW6CeGAhPzwm+Bvyp0VCQUvRrgNjhPv5=jNYxzpw@mail.gmail.com>
Subject: Re: [PHP-DEV] Was removing major version from apache module a
 mistake?
From: dan@cpanel.net (Dan Muey)

--Apple-Mail=_08A971E1-E878-41D7-BC11-E55D886A02AF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

thanks Nikita, we didn=E2=80=99t notice until we went to build the beta =
and RC RPMs in prep for release.=20

We looked over the breaking changes list but I guess we didn=E2=80=99t =
read far enough down the entire changes list.

Dropping DSO is not a bad thing since there are so many other better =
ways to serve PHP.

> On Nov 18, 2020, at 4:04 PM, Nikita Popov <nikita.ppv@gmail.com> =
wrote:
>=20
> On Wed, Nov 18, 2020 at 10:54 PM Dan Ackroyd <Danack@basereality.com =
<mailto:Danack@basereality.com>> wrote:
> On Tue, 10 Nov 2020 at 20:22, Dan Muey <dan@cpanel.net =
<mailto:dan@cpanel.net>> wrote:
> >
> > Hello,
> >
> > Was removing the major version from apache module done on purpose
>=20
> It was done on purpose on 28 Jan 2019 =
https://github.com/php/php-src/pull/3769 =
<https://github.com/php/php-src/pull/3769>
>=20
> Although it is annoying to have minor things like this change,
> projects need to be able to correct small mistakes instead of leaving
> them until the end of time.
>=20
> =46rom elsewhere:
> > Conclusion Let=E2=80=99s =E2=80=9CDrop DSO in 8=E2=80=9D for now, =
and if there is a large push to reinstate it, then
> > revisit our options starting with the simpler =E2=80=9CPatch PHP 8 =
to undo upstream=E2=80=99s change=E2=80=9D.
>=20
> Sounds good to me.
>=20
> cheers
> Dan
> Ack
>=20
> FWIW, as the person who implemented the change, there was no very =
strong reason to do it, it was just routine cleanup to drop major =
version numbers in all places where they are not needed for technical =
reasons. (We used to have hundreds of files that needed to be changed =
when the major version number changed.)
>=20
> If I had known at the time, or really at any point in the following =
one and a half years, that this causes issues for cpanel, I would have =
simply reverted the change, because it would be more trouble than it is =
worth. However, as the issue only came up pretty late, many other =
projects will have accounted for the new name by now and would be broken =
if we changed it back.
>=20
> Regards,
> Nikita

--
Dan Muey=E2=9E=9CcPanel::D3v::Zer=C3=98Cool


--Apple-Mail=_08A971E1-E878-41D7-BC11-E55D886A02AF--